From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 2F2A13858D39 for ; Mon, 27 Mar 2023 14:14:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F2A13858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12d.google.com with SMTP id j6so4679007ilr.7 for ; Mon, 27 Mar 2023 07:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1679926462; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XsDiFSkmmgGH9v5htTvBCo58sVsRrgBUmZK1CnOTU6k=; b=XJPA09QzVzJ5H6dBsDwbgvPlVtr31ex4zfenCkg/QlFielxPqQqutawirMZOulrd9g CN9KWO11I578eG0OSACpPQyWsJXvTm/DGp78KcmC9yyJk9oT+WjrH1p67ODMvwISZmYE S9oidjzIwwvOzh/Q6Wk4vU8hqteWt13FIS9m4bc1HjWClGnxvD3jOxg9po6zW62Xn4fI HaJik2Mp4U/MTO9HNmMH8/9Q/Ps0hW4UUrImdT/PQ+DXv+svIhWPRxfp+22RgyJGy1Yy AOfKIeIn+RHfRbDwnr6bjsgYCqBdWxdQ3KtkI726pimUyMnOT+BJY4Lx2ycWInSJ/tUN HQWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679926462; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XsDiFSkmmgGH9v5htTvBCo58sVsRrgBUmZK1CnOTU6k=; b=0zq+K90bLG4YGta9pvTqzfAn43r5vNRZO3qQuOirAB9Eq0ZnyUcEyJTq0I5TP6RwNZ weSlRal+b30WQ0ctfv9P+i4xhdM5NLkVArEWVs2JOdFj/HH1BJjeP8GjBNdKhsH4vNYf kAzLOzqN4f7+JyLfOvYV0lAzfThJdff++8d/lG5Vt3XclpXTYp3sSaWbh1CFHZAnd6Pv DJZ2iqvxpqy0PG1mLPVZI2K6sfDglJzCHp8TIDZ3uTIQlBQDk3nyB3uKorWd3QJGv8oh TSd8Ca8R7atCSs+OJiXWTe/6tgbXMF4YSH9KIJu3qcw9iSd0hmsupv+H0lRS0BHFcPCL WEoA== X-Gm-Message-State: AAQBX9cN++Wn2Njepl/v0K0gH839q2UJpeWhAYyWIcsnoQnILhpM7ZHr IEkZ8OJNUL8q02VnpkUh1XTauw== X-Google-Smtp-Source: AKy350ZWbdRtvgIy7bNJww5OLRjrHT3Pa3YcxzYdeDz/W9uCFT6elycy5BvyJCpaJTrlQY2Cdnj9HQ== X-Received: by 2002:a92:d342:0:b0:313:bf44:b4a5 with SMTP id a2-20020a92d342000000b00313bf44b4a5mr9616919ilh.13.1679926462414; Mon, 27 Mar 2023 07:14:22 -0700 (PDT) Received: from murgatroyd (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id y19-20020a056e02119300b00325de773339sm2465201ili.64.2023.03.27.07.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 07:14:22 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [RFC] Populate seen_names hash in cooked_index_shard::do_finalize References: <20230210142132.2039087-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 27 Mar 2023 08:14:21 -0600 In-Reply-To: <20230210142132.2039087-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Fri, 10 Feb 2023 07:21:32 -0700") Message-ID: <87355qe0xu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> Hannes pointed out that cooked_index_shard::do_finalize never Tom> populates the seen_names hash table. This patch adds the necessary Tom> store. This reduces memory use a little for "gdb gdb": I'm going to check this in, and also backport it to the gdb 13 branch. Tom