From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 94D2A3858D38 for ; Fri, 10 Mar 2023 22:16:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94D2A3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678486589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z59KrF61Z9l5+AK5JCMi8efGxTIhuTifLHnLN+MjZLg=; b=MTKPdDljzu7yhbn68n2lULRtL9hY8DDAA0z//9f3tUKJWOaLXM+QGpu5fifDn83I4of9ie 9eNertGUPkHzFoP5KoDaOJxpTcHmCW4mi1H6JX5cbmJwsaX0a0fxtgD8tvjKRONszKNBLc wlDMIwKm5OOMLZ58L7INiPfu+PdvX/Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-UsAlc08vOAuCPgO_J3QNpA-1; Fri, 10 Mar 2023 17:16:27 -0500 X-MC-Unique: UsAlc08vOAuCPgO_J3QNpA-1 Received: by mail-wm1-f70.google.com with SMTP id az12-20020a05600c600c00b003e8910ec2fdso2332703wmb.6 for ; Fri, 10 Mar 2023 14:16:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678486586; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z59KrF61Z9l5+AK5JCMi8efGxTIhuTifLHnLN+MjZLg=; b=ZQtn/GUrls3U4JqWJDFX9kCHM8LB+W1x02wM+MgmfgT83zNbxUXNsNaCji4t1vDINg CsECq4tgmqnVj9F09FPNzw52O2Ko4k8aONrIPXkBzP1Vpwt3ZPY/S8y1fCmBojUnkzFI 71zdW4PHm8+MLM3vJXK5CPdhyOhofDwpfsxV6PAGZlXZefA3gGOouGO2dLsZMyrq4fIR 3tehS8AlTuvYurW5pXPZXknbdlClS2fDC5fH30BnE8Vezb6UcP+uJGscBdZo541uk/VN aoGi0vQl61NuNM4aRtTdXFgfUdcmUTzRzzHki0cglnfGs/q0iSF1OPdR1xfnXlH0bhUc Aybw== X-Gm-Message-State: AO0yUKWYDUEs74XokOVmFDZ727UFjMzTFbSPapt+vrV1i4W6NcGg4XHJ TG84waTQQ0zE+ZD7seHEt2+CHewLUo8kXhBY/vWUylcUr50FewLLrUFqkD+3SjJVeyfre3uSaTl HmZSKmPUmIhAUvE4+94OanyRcVgWsDw== X-Received: by 2002:a05:600c:4748:b0:3e7:f108:664c with SMTP id w8-20020a05600c474800b003e7f108664cmr4002135wmo.40.1678486586684; Fri, 10 Mar 2023 14:16:26 -0800 (PST) X-Google-Smtp-Source: AK7set+FpcOk/BBqzC/gstSDfLmzdHc1iFXT4y50Vt0tEILk4nx8vzXWQjHq8aEwu35aOovLEukdTw== X-Received: by 2002:a05:600c:4748:b0:3e7:f108:664c with SMTP id w8-20020a05600c474800b003e7f108664cmr4002124wmo.40.1678486586385; Fri, 10 Mar 2023 14:16:26 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id m27-20020a05600c3b1b00b003e733a973d2sm1112383wms.39.2023.03.10.14.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 14:16:25 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 09/10] gdb/python: Allow gdb.UnwindInfo to be created with non gdb.Value args In-Reply-To: <87sfecliwt.fsf@tromey.com> References: <9da6361cc56f184b6a44b1086d9fbeae6d30eab9.1678460067.git.aburgess@redhat.com> <87sfecliwt.fsf@tromey.com> Date: Fri, 10 Mar 2023 22:16:24 +0000 Message-ID: <87356cgslj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> Currently all of these frame-id attributes need to be gdb.Value > Andrew> objects, but the only reason for that requirement is that we have some > Andrew> code in py-unwind.c that only handles gdb.Value objects. > > Andrew> If instead we switch to using get_addr_from_python in py-utils.c then > Andrew> we will support both gdb.Value objects and also raw numbers, which > Andrew> might make things simpler in some cases. > > FWIW this was https://sourceware.org/bugzilla/show_bug.cgi?id=19314 > which I closed for reasons I no longer really understand. That would indeed appear to be a similar issue, but it's not the exact same problem - at least, the code mentioned in that bug isn't touched by this series. This patch is specifically about the frame-id object which needs to be passed to the PendingFrame.create_unwind_info call. That frame-id object needs to have 'sp' and 'pc' attributes, which previously had to be gdb.Value objects, but can now be raw integers. The code mentioned in that bug is for the UnwindInfo.add_saved_register method, which takes a register-id and a register value, the value, it would seem, also has to be a gdb.Value. I haven't tried to change that, but I could take a look. Thanks, Andrew