From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 631483857C45 for ; Fri, 24 Feb 2023 19:55:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 631483857C45 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id DB96710042F93 for ; Fri, 24 Feb 2023 19:55:17 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VeA1poxbOPH6mVeA1p2RuU; Fri, 24 Feb 2023 19:55:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=evcacqlX c=1 sm=1 tr=0 ts=63f91625 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=2Q5KrQv9X-520bFQaXsA:9 a=hNtI24ROayEA:10:mobile_email_address_1 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hLR6IRgOZWO7LWgMhRZnov4m84q8VGQEuWxPrdZx6KM=; b=tTdnXA8SZPpJtjyHMd8d/rGzKU iE9o/K0ruAzsEYmBgKZdIEmLs13U4B2uCPBfmuQloPaYbv0r97LbNGehPTg2cVs2H0ruwB1Xjju+8 DB0V/br8Xzx4bJUE2c1HG0JN2; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:59944 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVeA1-002ONf-9h; Fri, 24 Feb 2023 12:55:17 -0700 From: Tom Tromey To: Alexey Lapshin via Gdb-patches Cc: Alexey Lapshin , Alexey Gerenkov , "tom@tromey.com" , Anton Maklakov , Ivan Grokhotkov , "jcmvbkbc@gmail.com" Subject: Re: [PATCH v2] gdb: xtensa: don't supply registers if they are not present References: <026589bb5fd46e8811b0909d048307261a8165b7.camel@espressif.com> X-Attribution: Tom Date: Fri, 24 Feb 2023 12:55:12 -0700 In-Reply-To: <026589bb5fd46e8811b0909d048307261a8165b7.camel@espressif.com> (Alexey Lapshin via Gdb-patches's message of "Fri, 24 Feb 2023 06:28:08 +0000") Message-ID: <87356uhm8v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pVeA1-002ONf-9h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:59944 X-Source-Auth: tom+tromey.com X-Email-Count: 21 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Alexey" == Alexey Lapshin via Gdb-patches writes: Alexey> +static inline bool Alexey> +is_reg_raw_supplied (int check_regnum, int regnum) In gdb, it's customary to have a comment before a function that explains its purpose. Tom