From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb/amd64: replace xmalloc/alloca with gdb::byte_vector
Date: Fri, 24 Feb 2023 12:12:43 -0700 [thread overview]
Message-ID: <87356uj2s4.fsf@tromey.com> (raw)
In-Reply-To: <810b37f52627188ebfba31684dac71f910a960d7.1677167272.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 23 Feb 2023 15:47:59 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> Replace a couple of uses of xmalloc and alloc with a gdb::byte_vector
Andrew> local variable instead.
Andrew> There should be no user visible changes after this commit.
Reviewed-By: Tom Tromey <tom@tromey.com>
I think we should remove all uses of alloca, then poison it.
Tom
prev parent reply other threads:[~2023-02-24 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:47 Andrew Burgess
2023-02-24 19:12 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87356uj2s4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).