From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 05CC83858C00 for ; Thu, 23 Feb 2023 20:21:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05CC83858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x133.google.com with SMTP id h10so1652802ila.11 for ; Thu, 23 Feb 2023 12:21:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AUO2HAbkaFEybsPfXgdR+ZPdo41wnG4gaPVftrTtJM0=; b=GplCm7qJgfvkpaT8RQ48CacBfsdwqHK4tLczsTvoRMYZLroktAhtFJ0yEWhrE9QeJk U/c6X1kIipELdbzNPnPZUa5MdWa65Phu7u7sAknCjPIxXTxBIvaPrx3xOOgIMPB+7ZUu jhDLGYQE6wngNqMR0FnUiveu/Z6cDLFt8BhTHVhLlVVISRHTOsam/HAXPqxIbocVokuL zSEBz1SHgksgIGyg+h1DdQvYxrVPhL7XceCwoOKXu/hVVP2i7G/xhnV+SZ+7jExGlVCL o3SsSvDmp8Lv5nXfVXgVhUIIO1xBR4oebIzFwfG3d8MBmRj5sCrKIxfhhrg+LzR/tfJ+ zHtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AUO2HAbkaFEybsPfXgdR+ZPdo41wnG4gaPVftrTtJM0=; b=rZa+Ic2HUoEDhg5HqNAnj54sahvHFR3fh+7OGm7Jd4ycQXNFSCUM2wSxytVgAj4qX3 YhtFhm7WCAukiW/LMkaE5uJRzOwot7o+rnaaN+gtO1BtpeM4NhnSwmawCMc7ynOP3Rl9 4avdKsAdrjFSRRAhy4tJ76iXQ/wZIi5IopUed7tVcVy3A/nt7kMxq/onvbXNufDPIBSR mqiv3/AeoJluOYhH55OJIXT9cJ/racWnIFkLqeAiLWiYBBBH/B/7w8ampYGfWmkHNurk 6pd3i7Bh5mfRjVMgmVX0K2JiJcZqIC6hzp9V3CHKFA1ov6x+66Wg+7qEp9tm73ojMKCr bc5g== X-Gm-Message-State: AO0yUKX+snezp5pBrjJHop1/yITRtv7KGugGKQMp3aX6wpjXHgehE2Nd 0qDlKhyelV6Nr8OqP0FtPMUic5vzNHkr6wE7 X-Google-Smtp-Source: AK7set+YUP6pDqVs1M5sJnHKlN7okg6eIdInBoJiNmIRLBYRB1HZLuj6Iw/5+QUoEI5bFAnIruDL+g== X-Received: by 2002:a92:5206:0:b0:315:7004:3e6a with SMTP id g6-20020a925206000000b0031570043e6amr10482237ilb.21.1677183695406; Thu, 23 Feb 2023 12:21:35 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id n18-20020a056638121200b003b8708902c0sm3216640jas.21.2023.02.23.12.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 12:21:35 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Implement DAP variables, scopes, and evaluate requests References: <20230223200806.2647349-1-tromey@adacore.com> X-Attribution: Tom Date: Thu, 23 Feb 2023 13:21:34 -0700 In-Reply-To: <20230223200806.2647349-1-tromey@adacore.com> (Tom Tromey's message of "Thu, 23 Feb 2023 13:08:06 -0700") Message-ID: <87356wjfox.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> The DAP code already claimed to implement "scopes" and "evaluate", but Tom> this wasn't done completely correctly. This patch implements these Tom> and also implements the "variables" request. Tom> diff --git a/gdb/testsuite/gdb.dap/scopes.exp b/gdb/testsuite/gdb.dap/scopes.exp Tom> +# Test DAP 'bt' through a function without debuginfo. After I sent it I noticed this copy-paste comment. I've updated it locally. Tom