From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id E3AD53858C2B for ; Mon, 13 Feb 2023 23:33:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3AD53858C2B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 56F2310042E33 for ; Mon, 13 Feb 2023 23:33:29 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RiK9pDsjWNX2aRiK9pyQfz; Mon, 13 Feb 2023 23:33:29 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63eac8c9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=S73vSfcq8lINSzOgGMYA:9 a=UkW63kcQHexeCySgLnd-:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aQxgQPD+ZmF1hkcd3E2hn+GQ+tY+abFuUq/tk89Tczw=; b=p4M7+KiMuy4OyLipKc2NQXIHp3 oC0sriVzRhI3OzdDqQeXy+Km+jZ//E7PhNXoM2DFfTr/GJUxuUWnYI9t8f2fxhcwCNghntwfk2xAP tXx1IIaLFPpqW7nrxmfh0R3bG; Received: from [161.98.8.3] (port=49538 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRiK8-001uGT-Mv; Mon, 13 Feb 2023 16:33:29 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 2/4] gdb/dwarf2: move some things to read.h References: <20230213145559.46676-1-simon.marchi@polymtl.ca> <20230213145559.46676-3-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Mon, 13 Feb 2023 16:33:24 -0700 In-Reply-To: <20230213145559.46676-3-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Mon, 13 Feb 2023 09:55:57 -0500") Message-ID: <873579dttn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.3 X-Source-L: No X-Exim-ID: 1pRiK8-001uGT-Mv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [161.98.8.3]:49538 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> The following 2 patches move .gdb_index and .debug_names reading code to Simon> their own file. Prepare this by exposing some things used by that code Simon> to read.h. Simon> +/* If FILE_MATCHER is NULL or if PER_CU has Simon> + dwarf2_per_cu_quick_data::MARK set (see Simon> + dw_expand_symtabs_matching_file_matcher), expand the CU and call Simon> + EXPANSION_NOTIFY on it. */ Simon> + Simon> +bool Simon> +dw2_expand_symtabs_matching_one Simon> + (dwarf2_per_cu_data *per_cu, Simon> + dwarf2_per_objfile *per_objfile, Simon> + gdb::function_view file_matcher, Simon> + gdb::function_view expansion_notify); Don't we normally write "extern" in headers? Also normally in declarations the type is on the same line as the function name. Simon> +/* This is a view into the index that converts from bytes to an Simon> + offset_type, and allows indexing. Unaligned bytes are specifically Simon> + allowed here, and handled via unpacking. */ Simon> + Simon> +class offset_view Simon> +{ Simon> +public: Simon> + offset_view () = default; I think this type should be specific to .gdb_index. It shouldn't be needed anywhere else -- it's there to work around the lack of alignment. If it is needed somewhere else, I suppose it's fine, it would just be better to refactor so that this can be an implementation detail of .gdb_index again. Tom