public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Simon Marchi via Gdb-patches <>
Cc: Simon Marchi <>
Subject: Re: [PATCH 1/2] gdb/dwarf: rename cooked_index to cooked_index_shard
Date: Tue, 31 Jan 2023 13:55:22 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Simon Marchi via Gdb-patches's message of "Tue, 31 Jan 2023 13:27:20 -0500")

>>>>> "Simon" == Simon Marchi via Gdb-patches <> writes:

Simon> I propose to rename cooked_index_vector and cooked_index such that the
Simon> "main" object, that is the entry point to the index, is called
Simon> cooked_index.  The fact that the cooked index is implemented as a vector
Simon> of smaller indexes is an implementation detail.

Agreed.  Thank you for doing this.

Approved-By: Tom Tromey <>


      parent reply	other threads:[~2023-01-31 20:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 18:27 Simon Marchi
2023-01-31 18:27 ` [PATCH 2/2] gdb/dwarf: rename cooked_index_vector to cooked_index Simon Marchi
2023-01-31 20:56   ` Tom Tromey
2023-02-01  3:09     ` Simon Marchi
2023-02-01  3:42       ` Tom Tromey
2023-01-31 20:55 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).