From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 051A53858D1E for ; Mon, 9 Jan 2023 19:27:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 051A53858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 6644F100400C3 for ; Mon, 9 Jan 2023 19:27:09 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ExnZpQhIhuK4dExnZpI2Ge; Mon, 09 Jan 2023 19:27:09 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=XpE/hXJ9 c=1 sm=1 tr=0 ts=63bc6a8d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=LFM1pNS4flVewjhM56wA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/rK4yE5qd1zHLW5raqlgZ8QTZJJHd2SuMWIPexYVJ44=; b=fNSv6V9oWkSL2yRM5QgXXDwdNM XO8F97vzI3GedIOtUQTLpDUhmhzxQ1lcRFyN7w88WfMqT8F2gKIDUEtV4uAjUNH2fWiBvXX0aOlmi mum6u0nnOsJogXeHYOPlfd4hM; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:33424 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pExnY-002mXs-So; Mon, 09 Jan 2023 12:27:08 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: Aaron Merey Subject: Re: [PATCH] gdb/linespec.c: Fix missing source file during breakpoint re-set. References: <20221007234428.12845-1-amerey@redhat.com> <20221012204916.467707-1-amerey@redhat.com> X-Attribution: Tom Date: Mon, 09 Jan 2023 12:27:05 -0700 In-Reply-To: <20221012204916.467707-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Wed, 12 Oct 2022 16:49:16 -0400") Message-ID: <87358ja4qe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pExnY-002mXs-So X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:33424 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> I'm reposting this patch with a testcase added to Aaron> testsuite/gdb.debuginfod/fetch_src_and_symbols.exp. I tried finding a Aaron> way to reproduce the error without debuginfod by using 'set Aaron> substitute-path' but the substitution rules always converted the symtab Aaron> fullname to the filename which avoided the error. Since I don't know Aaron> of any other way to trigger the error other than with source files Aaron> downloaded from debuginfod, the gdb.debuginfod seems like the best (only?) Aaron> place for the test. Sorry about the long delay on this. It's pretty hard to review a patch like this, since it's hard to know what impact it might have. However I am mostly fine with it (see the end), assuming you regression-tested it. Aaron> + gdb_test "run" "Breakpoint 1,.*" \ Aaron> + "file [file tail $binfile] set breakpoint]" I think there's an unmatched "]" here. Tom