From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 1E54B3858D35 for ; Tue, 29 Nov 2022 04:33:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E54B3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22f.google.com with SMTP id m204so13968183oib.6 for ; Mon, 28 Nov 2022 20:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=houuU81YPEhatI8YCKrWjUYcFsbKu6bSNGeYW+jGy30=; b=WTnUxDKphWd0/0BVNcUdpDCZ/1qoS7ymvYY7Rbu06G2/cqoaj3bcG5Z56EN5Z2o+8r jFBh4i3DqetDMNK1nUEp9KfyPHwtSZEUETyJ/0CqKw64WWlo/VuuV9UfIaJ0QYtZIZDG ua+Pl695jTyCR+cDn6r58G5cR2GMfZJc7ZN0zd0YtjHg5wCuQ4FLu5jShS2vFz7nthZ+ qZRjaeuqfBkT0c0hTLHFmUuDtZtcFABH0/1E8WJkbrqqhFCmcsEpJfj1MZZAxHWQ/ViV KnyqpnjxQ19+2pEVoDGekPgkOf2/nhlDZjdksWyP1D0nLZWEe6k0QUd+64QJE9pH8IZb SUQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=houuU81YPEhatI8YCKrWjUYcFsbKu6bSNGeYW+jGy30=; b=PzPMMrZSn1mGoeIxmJlj3rlUI0ehKP9y+PFNYLIDy9B3Rk3ZVwRI7rxIGBAvCdVmrq 3e9LNDO27Q5sUvIKtyrj0KPStHhEyLqYolQPa0WTbsHOh0m9cd27h/zXqhM7hKO7I2Lt SiaYQyNOJdJAEbvE4WhhUtFYyxjBYNImXUKW5UVY+uILMoo+F2QDb9tZNbi1ebedsbk7 IaTc3zn+eCxz9T3yVQMhwAoaA3oA2Mp/ujjHNhPNWNITijXe+odiiJwfjsv1oMvogQc+ yKI4acvPMf1JIrdKmPimWdxlvKFGAr1JVqJb+DfivnEmV5TJK8IYxuJSMs7xF1TuPtFC 2HPg== X-Gm-Message-State: ANoB5pmiIy/G0Q2Ik4Jcv4qCw9JowjT2U2efZzOP+zXKJAHUPogvYv0y L/XiCb1uVvcbMOF62kiSNoxNwQ== X-Google-Smtp-Source: AA0mqf6Do3CbyYIAVi4lS6v6iGTn5mliO8AG3u/Hf2/Dcf+zsBJxLpRZvGEkcYsx6NGYEYmQWd8bzw== X-Received: by 2002:a05:6808:159a:b0:35a:f68e:7ddf with SMTP id t26-20020a056808159a00b0035af68e7ddfmr18009939oiw.34.1669696394478; Mon, 28 Nov 2022 20:33:14 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:201c:ea26:41ce:5eb]) by smtp.gmail.com with ESMTPSA id h9-20020a4a6b49000000b0049e9a80c690sm5097427oof.1.2022.11.28.20.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 20:33:14 -0800 (PST) References: <20221126020452.1686509-1-thiago.bauermann@linaro.org> <20221126020452.1686509-6-thiago.bauermann@linaro.org> <44aeec44-7c18-f165-44a7-664a96c368e8@simark.ca> User-agent: mu4e 1.8.11; emacs 28.2 From: Thiago Jung Bauermann To: Simon Marchi Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH v2 5/6] gdb/aarch64: Factor out most of the thread_architecture method In-reply-to: <44aeec44-7c18-f165-44a7-664a96c368e8@simark.ca> Date: Tue, 29 Nov 2022 04:33:11 +0000 Message-ID: <8735a2gz20.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi writes: >> /* Implement the "supports_memory_tagging" target_ops method. */ >> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c >> index 07330356fdcb..ffc128d91f60 100644 >> --- a/gdb/aarch64-tdep.c >> +++ b/gdb/aarch64-tdep.c >> @@ -3486,6 +3486,41 @@ aarch64_cannot_store_register (struct gdbarch *gdbarch, int regnum) >> || regnum == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base)); >> } >> >> +/* Helper function for the "thread_architecture" target_ops method. >> + >> + Returns a new gdbarch that is equivalent to the given gdbarch, but with SVE >> + registers reflecting the given vq value. */ >> + >> +struct gdbarch * >> +aarch64_update_gdbarch (struct gdbarch *gdbarch, uint64_t vq) > > Document this using: > > /* See aarch64-tdep.h. */ > > ... and move the doc to the header file. I did that for v3. > Otherwise: > > Approved-By: Simon Marchi Thanks! Added the Approved-by tag to the patch description for v3. -- Thiago