From: Andrew Burgess <aburgess@redhat.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Tsukasa OI <research_trasio@irq.a4lg.com>,
Mike Frysinger <vapier@gentoo.org>,
Stephane Carrez <Stephane.Carrez@gmail.com>,
"Frank Ch . Eigler" <fche@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF
Date: Tue, 11 Oct 2022 15:27:30 +0100 [thread overview]
Message-ID: <8735bucu5p.fsf@redhat.com> (raw)
In-Reply-To: <9ee0350e33400397851bb55c129a675519e5f174.1665038133.git.research_trasio@irq.a4lg.com>
Tsukasa OI <research_trasio@irq.a4lg.com> writes:
> Clang generates a warning if the format string of a printf-like function is
> not a literal ("-Wformat-nonliteral"). On the default configuration, it
> causes a build failure (unless "--disable-werror" is specified).
>
> To avoid warnings on the printf-like wrapper, it requires proper
> __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.
>
> This commit adds ATTRIBUTE_PRINTF to the printf-like functions.
I've pushed this patch, but I moved all the ATTRIBUTE_PRINTF attributes
to the function declarations.
Also, one of the definitions already had an ATTRIBUTE_NORETURN, I moved
this to the declaration too.
Thanks,
Andrew
---
commit 3efe5b4d9e431f58a17e38d17419d6bcc3a4dd11
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date: Thu Oct 6 06:36:32 2022 +0000
sim/ppc: Add ATTRIBUTE_PRINTF
Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral"). On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).
To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.
This commit adds ATTRIBUTE_PRINTF to the printf-like functions.
For the error function defined in sim_calls.c, the ATTRIBUTE_NORETURN
has been moved to the function declaration.
diff --git a/sim/ppc/misc.h b/sim/ppc/misc.h
index 784ccfdd37b..08309134337 100644
--- a/sim/ppc/misc.h
+++ b/sim/ppc/misc.h
@@ -30,8 +30,8 @@
#include "ansidecl.h"
#include "filter_filename.h"
-extern void error
-(const char *msg, ...);
+extern void error (const char *msg, ...)
+ ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
#define ASSERT(EXPRESSION) \
do { \
@@ -47,8 +47,8 @@ do { \
extern void *zalloc
(long size);
-extern void dumpf
-(int indent, const char *msg, ...);
+extern void dumpf (int indent, const char *msg, ...)
+ ATTRIBUTE_PRINTF (2, 3);
extern unsigned target_a2i
(int ms_bit_nr,
diff --git a/sim/ppc/sim_callbacks.h b/sim/ppc/sim_callbacks.h
index 08ccd258569..c5f23bf8d64 100644
--- a/sim/ppc/sim_callbacks.h
+++ b/sim/ppc/sim_callbacks.h
@@ -31,9 +31,8 @@
void sim_io_printf_filtered
(const char *msg, ...) ATTRIBUTE_PRINTF_1;
-void ATTRIBUTE_NORETURN error
-(const char *msg, ...);
-
+extern void error (const char *msg, ...)
+ ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
/* External environment:
diff --git a/sim/ppc/sim_calls.c b/sim/ppc/sim_calls.c
index fbc327c94e0..729f6dcb6f3 100644
--- a/sim/ppc/sim_calls.c
+++ b/sim/ppc/sim_calls.c
@@ -388,7 +388,7 @@ sim_io_error (SIM_DESC sd, const char *fmt, ...)
/****/
-void ATTRIBUTE_NORETURN
+void
error (const char *msg, ...)
{
va_list ap;
next prev parent reply other threads:[~2022-10-11 14:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 8:44 [PATCH 0/7] sim, sim/ARCH: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 1/7] sim: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 2/7] sim/cris: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 3/7] sim/erc32: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 4/7] sim/m32c: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 5/7] sim/m68hc11: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 6/7] sim/ppc: " Tsukasa OI
2022-10-05 10:57 ` Andrew Burgess
2022-10-06 5:32 ` Tsukasa OI
2022-09-25 8:44 ` [PATCH 7/7] sim/rl78: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 0/7] sim, sim/ARCH: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 1/7] sim: " Tsukasa OI
2022-10-11 14:24 ` Andrew Burgess
2022-10-06 6:36 ` [PATCH v2 2/7] sim/cris: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 3/7] sim/erc32: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 4/7] sim/m32c: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 5/7] sim/m68hc11: " Tsukasa OI
2022-10-11 14:25 ` Andrew Burgess
2022-10-06 6:36 ` [PATCH v2 6/7] sim/ppc: " Tsukasa OI
2022-10-11 14:27 ` Andrew Burgess [this message]
2022-10-12 8:29 ` Jan-Benedict Glaw
2022-10-12 9:39 ` Andrew Burgess
2022-10-12 10:36 ` Jan-Benedict Glaw
2022-10-12 12:15 ` Jan-Benedict Glaw
2022-10-12 12:50 ` Jan-Benedict Glaw
2022-10-12 13:16 ` Tsukasa OI
2022-10-12 12:38 ` [PATCH 0/1] sim/ppc: Fix erroneous error calls (supplement) Tsukasa OI
2022-10-12 12:38 ` [PATCH 1/1] sim/ppc: Fix core_find_mapping diagnostics Tsukasa OI
2022-10-12 13:50 ` Andrew Burgess
2022-10-23 12:46 ` [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF Mike Frysinger
2022-10-06 6:36 ` [PATCH v2 7/7] sim/rl78: " Tsukasa OI
2022-10-11 14:23 ` [PATCH v2 0/7] sim, sim/ARCH: " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735bucu5p.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=Stephane.Carrez@gmail.com \
--cc=fche@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=research_trasio@irq.a4lg.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).