From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 94E263858D28 for ; Tue, 11 Oct 2022 19:59:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 94E263858D28 Received: by mail-io1-xd30.google.com with SMTP id l127so11763230iof.12 for ; Tue, 11 Oct 2022 12:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IJbkKgVhcic1+XYOzrrC8XDoNTo+kTM0aLtsgjnFZZE=; b=d2WDr31GFteWZnX2cNsC84i0i7Xie9VmMqJNKrTg682ZKf7xz5BcyN2OEOY6sv5eE0 3LRRA3k3W2GyaMlUA/NPHmghiqUaxxslhhLL8J+YpgATXNTkXNf9q5MKn+ll5hQ//q9C TIB98IF9eJxgUVlwYoComULBop1KrNFChs1hBEo+CBAF0hiCPwcVgHAt2fNAlQbM9eWp BKebkAURxpTBf1HHfYRuwsH/pyJc0Djy6w2LE/8dYma/dMl0KRvURa6vRS+KqGy/6UH9 td3ZMUljGMUzIHs6Gj4k3jFbu4IK2DllHhLDd9VN7G9WvdMaIqOhZSuvFTpXUPCK7wyW CGEg== X-Gm-Message-State: ACrzQf1LlRVrYA65UbAekhXSTxJoEKHOt1vgahWDh+WMp/SkymiNyUHc XKhMqg9jSVzABZpxlWy0BbvXUoOcFpqjcw== X-Google-Smtp-Source: AMsMyM5pwNG9PzQYeVWP54KI7CtwMlc9/dV10u86M/x/dqXtWbMhMeoemJ3uLnOjnbbnj8EYEVDTHQ== X-Received: by 2002:a05:6638:22c5:b0:35a:88fa:3d3a with SMTP id j5-20020a05663822c500b0035a88fa3d3amr13473289jat.115.1665518362871; Tue, 11 Oct 2022 12:59:22 -0700 (PDT) Received: from murgatroyd (71-211-160-49.hlrn.qwest.net. [71.211.160.49]) by smtp.gmail.com with ESMTPSA id t9-20020a92c909000000b002f50fb937f0sm5176947ilp.27.2022.10.11.12.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 12:59:22 -0700 (PDT) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] Fix .gdb_index with Ada References: <20220922202054.2773698-1-tromey@adacore.com> <03994f80-2aa9-e30a-2cab-d458b402e148@suse.de> X-Attribution: Tom Date: Tue, 11 Oct 2022 13:59:21 -0600 In-Reply-To: <03994f80-2aa9-e30a-2cab-d458b402e148@suse.de> (Tom de Vries's message of "Wed, 28 Sep 2022 04:00:19 +0200") Message-ID: <8735buqgh2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2022 19:59:27 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> The gdb.base/c-linkage-name.exp FAIL does look relevant to this Tom> series, and probably was regressed by the same offending commit. I see this was failing before my series -- but it works in gdb 12. So, it's one of the regressions the series was intended to fix :( Tom> Doing: Tom> ... Tom> diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c Tom> index ae05946e790..0268371ec2e 100644 Tom> --- a/gdb/dwarf2/index-write.c Tom> +++ b/gdb/dwarf2/index-write.c Tom> @@ -1167,7 +1167,6 @@ write_cooked_index (cooked_index_vector *table, Tom> minimal symbols anyway, so including it in the index is Tom> usually redundant -- and the cases where it would not be Tom> redundant are rare and not worth supporting. */ Tom> - continue; Tom> } Tom> gdb_index_symbol_kind kind; Tom> ... Tom> fixes the FAIL, so is this one of the "rare and not worth supporting" Tom> cases you're referring to? I thought that was necessary to avoid redundancy in the index, but I see now it isn't, or at least not in that way. I'm looking again at why the new indices are larger in general. Tom