From: Tom Tromey <tom@tromey.com>
To: TaiseiIto via Gdb-patches <gdb-patches@sourceware.org>
Cc: TaiseiIto <taisei1212@outlook.jp>
Subject: Re: [PATCH] Since "return NULL" and "return 0" were mixed in a function, unified to "return NULL".
Date: Mon, 12 Sep 2022 14:12:23 -0600 [thread overview]
Message-ID: <8735cw8i8o.fsf@tromey.com> (raw)
In-Reply-To: <TY0PR0101MB4285AFA968D3376157083209A4429@TY0PR0101MB4285.apcprd01.prod.exchangelabs.com> (TaiseiIto via Gdb-patches's message of "Sat, 10 Sep 2022 23:24:30 +0900")
>>>>> TaiseiIto via Gdb-patches <gdb-patches@sourceware.org> writes:
> The function "gdbarch_find_by_info" in "binutils-gdb/gdb/arch-utils.c"
> returns 0 on line 1363, but returns NULL on line 1376. I unified to
> "return NULL" because it is better representation than the other to
> indicate an invalid address.
I think if you're going to modify it, you might as well update all the
'NULL's in that function to 'nullptr' instead.
Tom
prev parent reply other threads:[~2022-09-12 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 14:24 TaiseiIto
2022-09-12 20:12 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735cw8i8o.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=taisei1212@outlook.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).