From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 32B7C383B797 for ; Mon, 25 Jul 2022 14:58:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32B7C383B797 Received: by mail-io1-xd30.google.com with SMTP id v185so8951756ioe.11 for ; Mon, 25 Jul 2022 07:58:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dAF89XWyZ04fZpybznXZWnBetzHxAnBvUtxp6n5ibGs=; b=HvAIXcG5WdbbZLy84MSBElTPUJob+6LQQXV03VUD84stuNlcva9WSe092uNgEjURLy TJGjtIaSWddjLp+SZMXo+EytY2ZBHiNvPgf9c44T2JlC/D+k9R4IzEa5i3FfPVAWyM0a p0jjdlfaPqWR3Us/2uzfPwCDUv29zMSLXlF4e9x7DqhRAnZ/QS0KYV8vKFvIxiQdB5Dk vKdfzrSUUZSvO/VwfdxYVnk/m8/BzE4C8KiliEz+weXxTqzag/ucQ/cBXW+s4gMx/LuY RwNU8OTYEzsNQiZ3M13fdwPJ1bYXVqPsjygsMlvYs6/GXKMSYQ/ad+D6gHdq6MxhB5qI NMMQ== X-Gm-Message-State: AJIora8Y7bR3bHf2DJzVAQ+f301rK8Hdv/Zu7o0qSIgLnYd5+UbL9h5K AciQfhkpxP9KMhljE1852y+r6V7HgB8s9g== X-Google-Smtp-Source: AGRyM1uJxCQkqCixnre4yaJMUAYjcEOjRQWap9jUM3pSlrmMNMAQbfBSqJuVKyffL72xc69fsdCJzQ== X-Received: by 2002:a05:6638:1a1a:b0:33f:405d:b1ed with SMTP id cd26-20020a0566381a1a00b0033f405db1edmr5134875jab.164.1658761123465; Mon, 25 Jul 2022 07:58:43 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id p3-20020a056638190300b0034142dad202sm5540697jal.31.2022.07.25.07.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 07:58:42 -0700 (PDT) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] struct packed and Windows ports (PR build/29373) References: <20220721152132.3489524-1-pedro@palves.net> X-Attribution: Tom Date: Mon, 25 Jul 2022 08:58:41 -0600 In-Reply-To: <20220721152132.3489524-1-pedro@palves.net> (Pedro Alves's message of "Thu, 21 Jul 2022 16:21:29 +0100") Message-ID: <8735epjl26.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 14:58:45 -0000 >>>>> "Pedro" == Pedro Alves writes: Pedro> PR build/29373 points out that mingw GDB builds are brokenly current, Pedro> failing static assertions in gdbsupport/packed.h. This series fixes Pedro> it, for both mingw + gcc, and mingw + clang. Please check these in. It would be good to have the Windows build working again. TBH I'm not sure any of this packed<> work is worth the effort, especially after seeing what's necessary for clang. The memory savings seem modest to me, considering that normally there aren't all that many CUs. OTOH I'd prefer a fix to go in. thanks, Tom