From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 4BF9A385275F for ; Mon, 18 Jul 2022 17:29:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4BF9A385275F Received: by mail-io1-xd35.google.com with SMTP id e69so2308664iof.5 for ; Mon, 18 Jul 2022 10:29:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MDvTKnVhFJqVqe/7oBYTBWxOvQ2zjdcN/xUQoJYocM0=; b=0lk/8QLKD43JdMr8MqXqxQDoL5SlqD2CBywHoDj4T3xG/w4Gok51sKIJ6ay7VWxIXP Rm/82NLi01oDuJmrOQwYmPXYtSr8HNrWSJ1bXybQKS1+ZrjhqJQu8KuiwvJ9zwL6WG6v Ikh1XKRpmNK3DRle4rn64vK66z/ajY5H0e5NIBnsK46rOrEBWDWRiXLdGXvf0DvdG6lt NqpNy9HZ+Iwysb6SxCAy8qt6evJejhFI2qyKulOaCafTLD/MPqyJmWoPK9nwv4B8MyXo rl6nAGRy17aJXCYsiDZd9q8TQ9aBh11Dj+FFPnciu42cXnLPJQB2lktn3q5qv36qWrTf xJWg== X-Gm-Message-State: AJIora+JDG0h8yBhkTKPgIjv9BAynIriwW0Kuu1cFUizYUCT5gtxUl9V 3tSpZXWMAoPAf7x8V0m9JLNgtA== X-Google-Smtp-Source: AGRyM1vXtungcIIBlS7mAvbrnn9OUklGghuZ/vCHDerl3Az4lQZNhRi6jxoLSXQM04o45B7AaLPvxw== X-Received: by 2002:a6b:700e:0:b0:675:9050:4101 with SMTP id l14-20020a6b700e000000b0067590504101mr13612721ioc.214.1658165340498; Mon, 18 Jul 2022 10:29:00 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id f10-20020a056e020c6a00b002dcf9e17a29sm296337ilj.76.2022.07.18.10.28.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 10:29:00 -0700 (PDT) From: Tom Tromey To: Kevin Buettner Cc: Tom Tromey via Gdb-patches , Tom Tromey Subject: Re: [PATCH] Make 'import gdb.events' work References: <20220607132025.2243948-1-tromey@adacore.com> <20220715133317.1bd0103b@f35-zws-1> X-Attribution: Tom Date: Mon, 18 Jul 2022 11:28:59 -0600 In-Reply-To: <20220715133317.1bd0103b@f35-zws-1> (Kevin Buettner's message of "Fri, 15 Jul 2022 13:33:17 -0700") Message-ID: <8735eyl484.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 17:29:02 -0000 >>>>> "Kevin" == Kevin Buettner writes: >> + /* Define all internal modules. These are all imported (and thus >> + created) during initialization. */ >> + struct _inittab mods[3] = >> + { >> + { "_gdb", init__gdb_module }, >> + { "_gdbevents", gdbpy_events_mod_func }, >> + { nullptr, nullptr } >> + }; Kevin> Something I just noticed while looking at a conflict while rebasing Kevin> my Python 3.11 deprecation patch: Kevin> Is there any reason not to do... Kevin> struct _inittab mods[] = Kevin> ... Kevin> instead? Not that I can think of, and I don't recall writing it this way :) It seems better to remove the '3' TBH. Tom