From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E281A383F847 for ; Tue, 31 May 2022 14:16:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E281A383F847 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-310-kCJkun72Mv-zjw2k1ahxKg-1; Tue, 31 May 2022 10:16:02 -0400 X-MC-Unique: kCJkun72Mv-zjw2k1ahxKg-1 Received: by mail-wr1-f69.google.com with SMTP id bv12-20020a0560001f0c00b0020e359b3852so2085774wrb.14 for ; Tue, 31 May 2022 07:16:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=yO6Qmwqz0dI5u8iho8UxCzO/SUAHYgOjaay8sFljEd8=; b=VTRAvumicN30p2lKO3ESM0AyXaYXn3whCFrea56W5K6jwHACPhhwfyI7dvZYJeYNsV Roz6vGIC2gz+JuUvbb5xO0vPyfqIpUqfJJ2lukDR75wxgc0lDNYPCSPVAqcMP/vcDHIo O/96sWwzS2xlTnGQJBvZcGpEBv67gzJL4Nh8r1Op4+hDVD8GHpO1FsnSzGBEo+Fp3eww dReHWcLUFBGd5NKoUcjPJp6l6HPy7/ElKxapjW1c1xAEtg0SCOvlRtLfdqKpYhQyjfnV HmeOgNmLSwXOLbSOVAMRzlCSqSZv7v0bH7UbqPbP9y6LKb0o4bfxVnv83ZQ6dT/aM152 RgYw== X-Gm-Message-State: AOAM531BAyIK4i5yTO6P30wAXmya7ajkYzEj3fWZ9STNCkGuo6V0zRBt 9IHOFvThG4w8AO/eCurKNhOQk5AGEGXp5LM4+ZQ3TulNjO+kn6mF/HGO0w8HW6+jtv2E4Y4me67 UDnXda8bgdZ6xL0WJA1vZrg== X-Received: by 2002:a7b:ce94:0:b0:397:82a5:dd05 with SMTP id q20-20020a7bce94000000b0039782a5dd05mr22480359wmj.161.1654006561410; Tue, 31 May 2022 07:16:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZiTPqLQ2AuGGk0pcHa5IW1jWJ8OwujlkMiemVd9EqcJigmXJp0xQfiIklDTeqCr28YE8xAQ== X-Received: by 2002:a7b:ce94:0:b0:397:82a5:dd05 with SMTP id q20-20020a7bce94000000b0039782a5dd05mr22480340wmj.161.1654006561179; Tue, 31 May 2022 07:16:01 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id m19-20020a05600c4f5300b003942a244f2esm2573986wmq.7.2022.05.31.07.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 07:16:00 -0700 (PDT) From: Andrew Burgess To: Nils-Christian Kempke , gdb-patches@sourceware.org Cc: JiniSusan.George@amd.com, Abdul Basit Ijaz Subject: Re: [PATCH v2 03/16] gdb/testsuite: Fix fortran types for Intel compilers. In-Reply-To: <20220531092423.2361679-2-nils-christian.kempke@intel.com> References: <20220531092423.2361679-1-nils-christian.kempke@intel.com> <20220531092423.2361679-2-nils-christian.kempke@intel.com> Date: Tue, 31 May 2022 15:15:59 +0100 Message-ID: <8735gpeqjk.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 14:16:10 -0000 Nils-Christian Kempke via Gdb-patches writes: > From: Felix Willgerodt > > Newer Intel compilers emit their dwarf type name in a slightly different > format. Therefore, this needs adjustment to make more tests pass in the > Fortran testsuite. > > Co-authored-by: Abdul Basit Ijaz > Co-authored-by: Nils-Christian Kempke > --- > gdb/testsuite/lib/fortran.exp | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) LGTM. Thanks, Andrew > > diff --git a/gdb/testsuite/lib/fortran.exp b/gdb/testsuite/lib/fortran.exp > index a97c6eeb4e..9531d393a1 100644 > --- a/gdb/testsuite/lib/fortran.exp > +++ b/gdb/testsuite/lib/fortran.exp > @@ -38,6 +38,8 @@ proc fortran_int4 {} { > return "integer" > } elseif {[test_compiler_info {icc-*}]} { > return "INTEGER\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "INTEGER\\*4" > } else { > return "unknown" > } > @@ -52,6 +54,8 @@ proc fortran_int8 {} { > return "integer\\*8" > } elseif {[test_compiler_info {icc-*}]} { > return "INTEGER\\(8\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "INTEGER\\*8" > } else { > return "unknown" > } > @@ -66,6 +70,8 @@ proc fortran_real4 {} { > return "real" > } elseif {[test_compiler_info {icc-*}]} { > return "REAL\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "REAL\\*4" > } else { > return "unknown" > } > @@ -80,6 +86,8 @@ proc fortran_real8 {} { > return "double precision" > } elseif {[test_compiler_info {icc-*}]} { > return "REAL\\(8\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "REAL\\*8" > } else { > return "unknown" > } > @@ -94,6 +102,8 @@ proc fortran_complex4 {} { > return "complex" > } elseif {[test_compiler_info {icc-*}]} { > return "COMPLEX\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "COMPLEX\\*8" > } else { > return "unknown" > } > @@ -108,6 +118,8 @@ proc fortran_complex8 {} { > return "double complex" > } elseif {[test_compiler_info {icc-*}]} { > return "COMPLEX\\(8\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "COMPLEX\\*16" > } else { > return "unknown" > } > @@ -122,6 +134,8 @@ proc fortran_complex16 {} { > return "quad complex" > } elseif {[test_compiler_info {icc-*}]} { > return "COMPLEX\\(16\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "COMPLEX\\*32" > } else { > return "unknown" > } > @@ -136,6 +150,8 @@ proc fortran_logical4 {} { > return "logical" > } elseif {[test_compiler_info {icc-*}]} { > return "LOGICAL\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "LOGICAL\\*4" > } else { > return "unknown" > } > @@ -150,6 +166,8 @@ proc fortran_character1 {} { > return "character" > } elseif {[test_compiler_info {icc-*}]} { > return "CHARACTER\\(1\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "CHARACTER\\*1" > } else { > return "unknown" > } > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928