From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id F08B73858D3C for ; Fri, 11 Mar 2022 15:27:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F08B73858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 554FF1003ED45 for ; Fri, 11 Mar 2022 15:27:23 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ShAon7uxJctgJShApnBRCG; Fri, 11 Mar 2022 15:27:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Oq2Kdwzt c=1 sm=1 tr=0 ts=622b6a5b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=m9mKeo-u2DBbOFS70twA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yYIKH4GYnwwEAIGTmf3B5pBHUWEftnKsDcbKX8zQ/LY=; b=yTlhOWECw1GX7YrNo1267cMzeg xXmq6Qy00IIc3Fwt1+vz+mljGCzkvGDMgBA68zK9nVZE4JTxMXhoSVdr9leL3Y+a/yfgL0SbaYyqO zScHbmVj2QwcpIf3GVxhO6UTb; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37970 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nShAo-0026qD-6s; Fri, 11 Mar 2022 08:27:22 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: tom@tromey.com, Aaron Merey , aburgess@redhat.com, lsix@lancelot.com Subject: Re: [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings References: <87wnh9u4m2.fsf@tromey.com> <20220308003331.171162-1-amerey@redhat.com> X-Attribution: Tom Date: Fri, 11 Mar 2022 08:27:21 -0700 In-Reply-To: <20220308003331.171162-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Mon, 7 Mar 2022 19:33:31 -0500") Message-ID: <8735jomrvq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nShAo-0026qD-6s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37970 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 15:27:25 -0000 >>>>> Aaron Merey via Gdb-patches writes: > gdb/corelow.c | 28 ++++++++++ > gdb/debuginfod-support.c | 51 +++++++++++++++++++ > gdb/debuginfod-support.h | 17 +++++++ > gdb/gcore.in | 2 +- > gdb/solib.c | 32 ++++++++++++ > .../gdb.debuginfod/fetch_src_and_symbols.exp | 22 ++++++++ > 6 files changed, 151 insertions(+), 1 deletion(-) This looks good to me. Thanks. > + if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT) > + printf_filtered (_("Download failed: %s. " \ > + "Continuing without executable for %ps.\n"), > + safe_strerror (-fd.get ()), > + styled_string (file_name_style.style (), filename)); I can't remember if I mentioned this before but it seems like a failure to download should probably always be reported. Maybe this ought to be an unconditional warning call. Tom