From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy9-pub.mail.unifiedlayer.com (alt-proxy16.mail.unifiedlayer.com [70.40.197.35]) by sourceware.org (Postfix) with ESMTPS id 7AA943858D39 for ; Mon, 20 Dec 2021 23:03:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7AA943858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 2F90E8CAA945 for ; Tue, 14 Dec 2021 20:42:53 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id xEdQm0837U08GxEdQmorIz; Tue, 14 Dec 2021 20:42:52 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=To0jOBbh c=1 sm=1 tr=0 ts=61b901cc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IOMw9HtfNCkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zd2uoN0lAAAA:8 a=CEwQLux_DudurfEh2zcA:9 a=zhNRY6AeDkkA:10:uccc_2email_address a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kzc0dpF/32ahNukhGCCKiP4zbBmzPxsLkTIG1zMqvTc=; b=HsiVs265JptNLMObnWwrl5shwK Edz5b0cLl9yB0ORZoGYbQcBcRVMfNr90e0LoIhrglMBV8RDWEfytNJ2rarPhkxifWyrR5bXuYjZ4V CaU8PGFXCcW40VPWP4KX88XtR; Received: from 75-166-130-34.hlrn.qwest.net ([75.166.130.34]:54308 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mxEdQ-000Lbu-AD; Tue, 14 Dec 2021 13:42:52 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH v4 02/28] Add new memory access interface to expr.c References: <20211105113849.118800-1-zoran.zaric@amd.com> <20211105113849.118800-3-zoran.zaric@amd.com> X-Attribution: Tom Date: Tue, 14 Dec 2021 13:42:51 -0700 In-Reply-To: <20211105113849.118800-3-zoran.zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Fri, 5 Nov 2021 11:38:23 +0000") Message-ID: <8735muzzn8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.34 X-Source-L: No X-Exim-ID: 1mxEdQ-000Lbu-AD X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-34.hlrn.qwest.net (murgatroyd) [75.166.130.34]:54308 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 23:03:22 -0000 >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> From: Zoran Zaric Zoran> DWARF expression evaluator is currently using a few different Zoran> interfaces for memory access: write_memory_with_notification, Zoran> read_value_memory, read_memory. Zoran> They all seem incosistent, while some of them even need a struct Zoran> value typed argument to be present. Zoran> This patch is simplifying that interface by replacing it with two new Zoran> low level functions: read_from_memory and write_to_memory. I kept thinking there must be a better way, like some existing API, but I looked at the other callers of target_xfer_partial and I think in the end I agree with the approach you took here. This looks ok to me. Thanks. Tom