public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,  Tom de Vries <tdevries@suse.de>
Subject: Re: [committed][gdb/testsuite] Disable vgdb tests if xml not supported
Date: Tue, 05 Oct 2021 12:15:50 -0600	[thread overview]
Message-ID: <8735pfz6ax.fsf@tromey.com> (raw)
In-Reply-To: <c39a2698-74fc-78b0-e025-cadaa953bb9e@suse.de> (Tom de Vries via Gdb-patches's message of "Thu, 30 Sep 2021 23:41:53 +0200")

Tom> Or perhaps you mean more generically (which wouldn't require us to write
Tom> a proc for each type of require):
Tom> ...
Tom> proc require { fn val } {
Tom>     if { [$fn] != $val } {
Tom>         untested "$fn != $val"
Tom>         return -code return 0
Tom>     }
Tom> }
Tom> ...
Tom> and:
Tom> ...
Tom> require gdb_skip_xml_test 0
Tom> ...
Tom> ?

Either seems fine but this one does read nicely to me.
Or maybe even just requiring 'fn' to return 0 would be good enough.

Tom

  parent reply	other threads:[~2021-10-05 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 13:55 Tom de Vries
2021-09-30 17:30 ` Tom Tromey
2021-09-30 21:41   ` Tom de Vries
2021-09-30 21:47     ` Tom de Vries
2021-10-05 18:15     ` Tom Tromey [this message]
2021-10-06  7:40       ` [PATCH][gdb/testsuite] Add proc require in lib/gdb.exp Tom de Vries
2021-10-07 11:00         ` [PATCH][gdb/testsuite] Prevent compilation fails with unix/-fPIE/-pie Tom de Vries
2021-10-08 14:37           ` Tom de Vries
2021-10-11 10:28         ` [PATCH][gdb/testsuite] Add proc require in lib/gdb.exp Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735pfz6ax.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).