From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.131]) by sourceware.org (Postfix) with ESMTPS id 79650385BF86 for ; Tue, 5 Oct 2021 18:15:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79650385BF86 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id DA44F1A751 for ; Tue, 5 Oct 2021 13:15:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id XoylmPrqXOnCIXoylm18T5; Tue, 05 Oct 2021 13:15:51 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=I1FlFanMulZKuDldrtxlmvsHXU3gTSJunKMCNtsVHaQ=; b=b7RXrkZveOEhWIqz2jzYPcQ/hg ge3O/op96DQRI/jD6N5LKBeNSuh8P8+FbE36hvi2e8mGGxhs376bn0/YUhTZ650nvFdz3B1+0Rgop yt0u6lJJXTU0SbkPFBxdX8OpS; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:53974 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mXoyl-000m5T-J5; Tue, 05 Oct 2021 12:15:51 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom Tromey , Tom de Vries Subject: Re: [committed][gdb/testsuite] Disable vgdb tests if xml not supported References: <20210929135520.GA16103@delia> <87pmsq0y4m.fsf@tromey.com> X-Attribution: Tom Date: Tue, 05 Oct 2021 12:15:50 -0600 In-Reply-To: (Tom de Vries via Gdb-patches's message of "Thu, 30 Sep 2021 23:41:53 +0200") Message-ID: <8735pfz6ax.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mXoyl-000m5T-J5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:53974 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 18:15:53 -0000 Tom> Or perhaps you mean more generically (which wouldn't require us to write Tom> a proc for each type of require): Tom> ... Tom> proc require { fn val } { Tom> if { [$fn] != $val } { Tom> untested "$fn != $val" Tom> return -code return 0 Tom> } Tom> } Tom> ... Tom> and: Tom> ... Tom> require gdb_skip_xml_test 0 Tom> ... Tom> ? Either seems fine but this one does read nicely to me. Or maybe even just requiring 'fn' to return 0 would be good enough. Tom