public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Weimin Pan via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH V5] CTF: multi-CU and archive support
Date: Fri, 11 Jun 2021 12:17:22 -0600	[thread overview]
Message-ID: <8735togtal.fsf@tromey.com> (raw)
In-Reply-To: <1621297225-2332-1-git-send-email-weimin.pan@oracle.com> (Weimin Pan via Gdb-patches's message of "Mon, 17 May 2021 20:20:25 -0400")

>>>>> ">" == Weimin Pan via Gdb-patches <gdb-patches@sourceware.org> writes:

>>  - Avoid calling ctf_dict_close more than once on a dictionary.]

>> +  ctf_ref (cfp);

I don't understand where the unref is done.
Maybe this just needs a comment or something, though?

Tom

  parent reply	other threads:[~2021-06-11 18:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  0:20 Weimin Pan
2021-05-25  0:52 ` [PING][PATCH " Wei-min Pan
2021-06-02  0:05   ` [PING 2][PATCH " Wei-min Pan
2021-06-09  0:37     ` [PING 3][PATCH " Wei-min Pan
2021-06-10  0:40 ` [PATCH " Lancelot SIX
2021-06-10 21:15   ` Wei-min Pan
2021-06-11 23:07     ` Lancelot SIX
2021-06-11 18:19   ` Tom Tromey
2021-06-11 23:14     ` Lancelot SIX
2021-06-11 18:17 ` Tom Tromey [this message]
2021-06-11 20:26   ` Wei-min Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735togtal.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).