From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.229]) by sourceware.org (Postfix) with ESMTPS id B2097383800F for ; Mon, 7 Jun 2021 14:53:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2097383800F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway22.websitewelcome.com (Postfix) with ESMTP id E51483B84 for ; Mon, 7 Jun 2021 09:53:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qGdVlicOLMGeEqGdVla7Hp; Mon, 07 Jun 2021 09:53:53 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dFji510IEPVc7ANJ8ZJtfrekhGP5uwWgMwxRkB6Oq0M=; b=WOYoMyg4hRDrQ6lNjEVEZ228K8 +uOHWjK7m+fIiOaTQ4mz4u2+xALUn7Jou5Dyj0FMsOLZVwDQ+QW6KSzLNLvXlkIoSBDPfSjILsDwH jU0LH9+27+L3Cd0YGrkMELWTo; Received: from 97-122-81-113.hlrn.qwest.net ([97.122.81.113]:50784 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lqGdV-003oFk-Gb; Mon, 07 Jun 2021 08:53:53 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] gdb/python: move PyLong_From* calls into py-utils.c References: <2e8e11d00b1eea71a99a49d5860deb3392372c91.1622321523.git.andrew.burgess@embecosm.com> X-Attribution: Tom Date: Mon, 07 Jun 2021 08:53:52 -0600 In-Reply-To: <2e8e11d00b1eea71a99a49d5860deb3392372c91.1622321523.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sat, 29 May 2021 21:57:11 +0100") Message-ID: <8735ttn2tb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.113 X-Source-L: No X-Exim-ID: 1lqGdV-003oFk-Gb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-113.hlrn.qwest.net (murgatroyd) [97.122.81.113]:50784 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 14:54:10 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> gdb/ChangeLog: Andrew> * python/py-inferior.c (infpy_get_connection_num): Call new Andrew> function gdb_py_object_from_int. Andrew> * python/py-utils.c (gdb_py_object_from_int): New function. Andrew> * python/python-internal.h (gdb_py_object_from_int): Declare. This seems fine to me. It would also probably be ok to just rely on promotion and always use gdb_py_object_from_longest. Tom