public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 17/22] Use the raw flag of automatic display to disable pretty printers
Date: Thu, 11 Mar 2021 14:47:05 -0700	[thread overview]
Message-ID: <8735x15pnq.fsf@tromey.com> (raw)
In-Reply-To: <20210306174102.21597-8-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Sat, 6 Mar 2021 18:40:57 +0100")

>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:

Hannes> diff --git a/gdb/python/lib/gdb/command/tui_windows.py b/gdb/python/lib/gdb/command/tui_windows.py
Hannes> index bd885e7e168..f6e10500db7 100644
Hannes> --- a/gdb/python/lib/gdb/command/tui_windows.py
Hannes> +++ b/gdb/python/lib/gdb/command/tui_windows.py
Hannes> @@ -201,21 +201,24 @@ class VariableWindow(TextWindow):
Hannes>              value = v.value()
Hannes>              sym_not_init = False
Hannes>              num = 0
Hannes> +            raw = False

I guess what is going on here is that this is parsing the "info display"
output, and other patches arrange to disable the ordinary display.

I think the Python hook idea would be preferable.
"display" could pass a gdb.Value to Python, along with format info (or a
list of these).

What do you think?

Tom

  reply	other threads:[~2021-03-11 21:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210306174102.21597-1-ssbssa.ref@yahoo.de>
2021-03-06 17:40 ` [PATCH 10/22] Add optional styled argument to gdb.execute Hannes Domani
2021-03-06 17:40   ` [PATCH 11/22] Use styled argument of gdb.execute() for cccw command Hannes Domani
2021-03-06 17:40   ` [PATCH 12/22] Add optional full_window argument to TuiWindow.write Hannes Domani
2021-03-06 18:13     ` Eli Zaretskii
2021-03-11 21:49     ` Tom Tromey
2021-03-06 17:40   ` [PATCH 13/22] Use the full_window argument of TuiWindow.write to prevent flickering Hannes Domani
2021-03-06 17:40   ` [PATCH 14/22] Add set_tui_auto_display python function Hannes Domani
2021-03-06 17:40   ` [PATCH 15/22] Disable automatic display while the display window is active Hannes Domani
2021-03-06 17:40   ` [PATCH 16/22] Show raw flag in info display Hannes Domani
2021-03-06 17:40   ` [PATCH 17/22] Use the raw flag of automatic display to disable pretty printers Hannes Domani
2021-03-11 21:47     ` Tom Tromey [this message]
2021-03-06 17:40   ` [PATCH 18/22] Update the source location with Frame.select Hannes Domani
2021-03-11 21:53     ` Tom Tromey
2021-03-06 17:40   ` [PATCH 19/22] Refresh the TUI source window when changing the frame in the frame window Hannes Domani
2021-03-06 18:13   ` [PATCH 10/22] Add optional styled argument to gdb.execute Eli Zaretskii
2021-03-08 10:01   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735x15pnq.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).