From: Tom Tromey <tom@tromey.com>
To: Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Shahab Vahedi <shahab@synopsys.com>,
Anton Kolesov <Anton.Kolesov@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH 1/2] arc: Add support for signal handlers
Date: Thu, 12 Nov 2020 10:47:32 -0700 [thread overview]
Message-ID: <87361eeabv.fsf@tromey.com> (raw)
In-Reply-To: <20201022165131.14763-2-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Thu, 22 Oct 2020 18:51:30 +0200")
>>>>> "Shahab" == Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> writes:
Shahab> + /* If we have a sigcontext_addr handler, then just use the default frame
Shahab> + sniffer. */
Shahab> + if ((tdep->sigcontext_addr != NULL) && (tdep->is_sigtramp != NULL)
Shahab> + && tdep->is_sigtramp (this_frame))
Shahab> + return default_frame_sniffer (self, this_frame, this_cache);
Shahab> + else
Shahab> + return FALSE;
The 'if' is over-parenthesized; but also obscure because
default_frame_sniffer just returns 1. How about just using
return (tdep->sigcontext_addr != NULL && tdep->is_sigtramp != NULL
&& tdep->is_sigtramp (this_frame));
Tom
next prev parent reply other threads:[~2020-11-12 17:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 16:51 [PATCH 0/2] arc: Add signal handling support Shahab Vahedi
2020-10-22 16:51 ` [PATCH 1/2] arc: Add support for signal handlers Shahab Vahedi
2020-11-12 17:47 ` Tom Tromey [this message]
2020-10-22 16:51 ` [PATCH 2/2] arc: Add support for signal frames for Linux targets Shahab Vahedi
2020-11-12 17:51 ` Tom Tromey
2020-11-10 19:12 ` [PING^1][PATCH 0/2] arc: Add signal handling support Shahab Vahedi
2020-12-07 16:36 ` [PATCH v2 " Shahab Vahedi
2020-12-07 16:36 ` [PATCH v2 1/2] arc: Add support for signal handlers Shahab Vahedi
2020-12-07 16:36 ` [PATCH v2 2/2] arc: Add support for signal frames for Linux targets Shahab Vahedi
2020-12-10 19:07 ` [PATCH v2 0/2] arc: Add signal handling support Tom Tromey
2020-12-22 11:13 ` [PUSHED v2 1/2] arc: Add support for signal handlers Shahab Vahedi
2020-12-22 11:13 ` [PUSHED v2 2/2] arc: Add support for signal frames for Linux targets Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87361eeabv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Anton.Kolesov@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).