From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 9D5DD3842411 for ; Tue, 21 Jul 2020 21:10:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9D5DD3842411 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ludo@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:36465) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxzXN-0005Bb-Fl; Tue, 21 Jul 2020 17:10:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56596 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxzXN-0000Fj-0T; Tue, 21 Jul 2020 17:10:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Marchi Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH v4 1/2] guile: Add support for Guile 2.2. References: <87v9jbi855.fsf@gnu.org> <20200628142540.11320-1-ludo@gnu.org> <20200718190038.GA582@adacore.com> <0a54056e-c491-6e87-5ad3-4f652f92383f@simark.ca> <87y2nezk5r.fsf@gnu.org> <0f542026-308a-495d-40a6-205c18b021eb@simark.ca> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Thermidor an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 21 Jul 2020 23:10:54 +0200 In-Reply-To: <0f542026-308a-495d-40a6-205c18b021eb@simark.ca> (Simon Marchi's message of "Mon, 20 Jul 2020 11:01:42 -0400") Message-ID: <87365kmv4x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 21:10:59 -0000 Simon Marchi skribis: > On 2020-07-20 4:05 a.m., Ludovic Court=C3=A8s wrote: >> Hi Simon, >>=20 >> Simon Marchi skribis: >>=20 >>> On 2020-07-18 3:00 p.m., Joel Brobecker wrote: >>>> Hi Simon, >>>> >>>>>> This primarily updates code that uses the I/O port API of Guile. >>>>> >>>>> I know nothing about Guile, so I just scanned the patch for any obvio= us >>>>> red flags, but didn't see any. The mess of #if statements sure is not >>>>> the best, but I don't have a concrete suggestion to make it better. >>>> >>>> I'm not confident that we'll be able to find a reviewer who has >>>> more experience with this part of the Code. What do you think of >>>> approving this patch series based on your review? >>> >>> Yeah, I think we can go ahead. Ludovic, do you have push access or wou= ld you like me to push it? >>=20 >> I do have access but I=E2=80=99m happy if you can push it for me. > > Done, thanks. Awesome, thank you! Ludo=E2=80=99.