From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 236A5383F849 for ; Mon, 15 Jun 2020 15:17:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 236A5383F849 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ludo@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:38426) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkqrG-0000QC-HV; Mon, 15 Jun 2020 11:17:10 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39852 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkqrG-0004YP-3w; Mon, 15 Jun 2020 11:17:10 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] guile: Add support for Guile 3.0. References: <20200612132710.14364-1-ludo@gnu.org> <20200612132710.14364-3-ludo@gnu.org> <87k108l6dm.fsf@tromey.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 15 Jun 2020 17:17:08 +0200 In-Reply-To: <87k108l6dm.fsf@tromey.com> (Tom Tromey's message of "Mon, 15 Jun 2020 09:02:13 -0600") Message-ID: <87366w1hqj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 15:17:12 -0000 Hi, Tom Tromey skribis: >>>>>> "Ludovic" =3D=3D Ludovic Court=C3=A8s writes: > > Ludovic> * testsuite/gdb.guile/source2.scm: Add #f first argument to > Ludovic> 'format'. > Ludovic> * testsuite/gdb.guile/types-module.exp: Remove "ERROR:" from > Ludovic> regexps since Guile 3.0 no longer prints that. > > testsuite/ (unfortunately IMO) has its own ChangeLog. Oops, will change it. > Ludovic> /* If scm_is_unsigned_integer can't work with this type, = just punt. */ > Ludovic> - if (TYPE_LENGTH (type) > sizeof (scm_t_uintmax)) > Ludovic> + if (TYPE_LENGTH (type) > sizeof (uintmax_t)) > > I suppose these can't differ in Guile 2.0 or 2.2? Correct. =E2=80=98scm_t_uintmax=E2=80=99 used to be provided by Guile but = it no longer makes sense now that C99 and its C++ counterpart are widely available. > Anyway, this patch seems fine to me. Thanks, Ludo=E2=80=99.