From: Tom Tromey <tom@tromey.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Add workaround from gdbserver's gdb_proc_service.h to GDB
Date: Fri, 28 Sep 2018 19:34:00 -0000 [thread overview]
Message-ID: <8736ttmn5b.fsf@tromey.com> (raw)
In-Reply-To: <1538146201-16374-3-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Fri, 28 Sep 2018 15:49:58 +0100")
>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
Gary> This commit adds a workaround from gdbserver's gdb_proc_service.h
Gary> to GDB's. It doesn't seem to have been needed on any glibc as far
Gary> back as 2001, but it's possibly required for other C libraries so
Gary> I've retained it.
This is ok.
Gary> * configure.ac: Check if sys/procfs.h defines elf_fpregset_t.
Gary> (AC_CHECK_HEADERS): Check for linux/elf.h.
Gary> * configure, config.in: Rebuild.
Gary> * gdb_proc_service.h: Include linux/elf.h if sys/procfs.h
Gary> doesn't define elf_fpregset_t.
It's mildly a shame to have to do this stuff for something so obsolete,
but on the other hand, due to caching I suppose it will hardly slow down
the build.
Tom
next prev parent reply other threads:[~2018-09-28 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 14:50 [PATCH 0/5] Merge common proc_service headers Gary Benson
2018-09-28 14:50 ` [PATCH 1/5] gdb_proc_service.h comment and whitespace synchronization Gary Benson
2018-09-28 19:28 ` Tom Tromey
2018-09-28 14:50 ` [PATCH 2/5] Add workaround from gdbserver's gdb_proc_service.h to GDB Gary Benson
2018-09-28 19:34 ` Tom Tromey [this message]
2018-09-28 14:50 ` [PATCH 3/5] Update GDB gdb_proc_service.h workaround to match gdbserver Gary Benson
2018-09-28 19:36 ` Tom Tromey
2018-09-28 14:58 ` [PATCH 4/5] Move duplicated code to common/gdb_proc_service.h Gary Benson
2018-09-28 19:40 ` Tom Tromey
2018-09-28 14:59 ` [PATCH 5/5][OPTIONAL] Remove ancient workaround Gary Benson
2018-09-28 19:44 ` Tom Tromey
2018-09-28 19:33 ` [PATCH 0/5] Merge common proc_service headers Tom Tromey
2018-09-28 19:46 ` Tom Tromey
2018-10-01 8:27 ` Gary Benson
2018-10-05 14:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736ttmn5b.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).