From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22876 invoked by alias); 28 Sep 2018 19:34:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22864 invoked by uid 89); 28 Sep 2018 19:34:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=obsolete X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.204) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Sep 2018 19:34:42 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 2DEB9244B40C for ; Fri, 28 Sep 2018 14:34:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5yXBgUS2faSey5yXBgskSm; Fri, 28 Sep 2018 14:34:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ICjoBmgMPAvaWx4MR+NST/zqqbAjgXl9IXiRjKnsk/w=; b=JqjIut6CRJ9lvBnfT3QcLDgi30 opeuRgVDm7M1Wgr6ZSEb3GjTunHn6xsGRKU+Qhb2MWQ3QuWsJrXwCO4Y+PEYmWOqcjF7ecdzfZ8pZ gfEo0yl5lPytQR6GYLE+9W9au; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:35620 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g5yXA-00098h-UX; Fri, 28 Sep 2018 14:34:41 -0500 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] Add workaround from gdbserver's gdb_proc_service.h to GDB References: <1538146201-16374-1-git-send-email-gbenson@redhat.com> <1538146201-16374-3-git-send-email-gbenson@redhat.com> Date: Fri, 28 Sep 2018 19:34:00 -0000 In-Reply-To: <1538146201-16374-3-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Fri, 28 Sep 2018 15:49:58 +0100") Message-ID: <8736ttmn5b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00910.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> This commit adds a workaround from gdbserver's gdb_proc_service.h Gary> to GDB's. It doesn't seem to have been needed on any glibc as far Gary> back as 2001, but it's possibly required for other C libraries so Gary> I've retained it. This is ok. Gary> * configure.ac: Check if sys/procfs.h defines elf_fpregset_t. Gary> (AC_CHECK_HEADERS): Check for linux/elf.h. Gary> * configure, config.in: Rebuild. Gary> * gdb_proc_service.h: Include linux/elf.h if sys/procfs.h Gary> doesn't define elf_fpregset_t. It's mildly a shame to have to do this stuff for something so obsolete, but on the other hand, due to caching I suppose it will hardly slow down the build. Tom