From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30097 invoked by alias); 4 Sep 2018 16:56:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29807 invoked by uid 89); 4 Sep 2018 16:56:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Sep 2018 16:56:09 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway21.websitewelcome.com (Postfix) with ESMTP id A8A4F400DF0E7 for ; Tue, 4 Sep 2018 11:56:07 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xEcLf1TkCbXuJxEcTfLlQe; Tue, 04 Sep 2018 11:56:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=R1Fr7qBumBOXY3m0EjVA0iHx6xRishXFfipvJWRQLuo=; b=AhMPSloEYlTjDiW+1WmA2pInJ6 cXXOkBHeLBCb/T0jouNu3T7luG242W510MY4jqF3X0rgvNzl2+TJSQj3i02kkqX1JV/rrR0oFe2+I /70AYccwdrn6J8fYIOFcjwIzW; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:35330 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fxEcL-002v8Q-4x; Tue, 04 Sep 2018 11:55:53 -0500 From: Tom Tromey To: Rainer Orth Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Remove cleanup from procfs.c References: <20180903190250.11599-1-tom@tromey.com> <20180903190250.11599-3-tom@tromey.com> Date: Tue, 04 Sep 2018 16:56:00 -0000 In-Reply-To: (Rainer Orth's message of "Tue, 04 Sep 2018 12:47:07 +0200") Message-ID: <8736upyzfs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-09/txt/msg00054.txt.bz2 >>>>> "Rainer" =3D=3D Rainer Orth writes: Rainer> I've now regtested the patch on amd64-pc-solaris2.11. Thank you for doing this. Rainer> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:275:13: error: =E2=80= =98void do_destroy_procinfo_cleanup(void*)=E2=80=99 declared =E2=80=98stati= c=E2=80=99 but never defined [-Werror=3Dunused-function] Rainer> static void do_destroy_procinfo_cleanup (void *); Rainer> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Rainer> by removing the unnecessary declaration, testing passed without Rainer> regressions (as far as I can tell with racy tests etc.). I've removed the declaration on my branch. Tom