From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32199 invoked by alias); 10 May 2018 20:54:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32177 invoked by uid 89); 10 May 2018 20:54:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 May 2018 20:54:17 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id D7775CD64 for ; Thu, 10 May 2018 15:54:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GsZrfv5sjBcCXGsZrfsq9P; Thu, 10 May 2018 15:54:15 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:35370 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fGsZr-001SKL-GN; Thu, 10 May 2018 15:54:15 -0500 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH RFC 3/5] Make index reading functions more modular References: <1525901216-15031-1-git-send-email-simon.marchi@ericsson.com> <1525901216-15031-4-git-send-email-simon.marchi@ericsson.com> Date: Thu, 10 May 2018 21:02:00 -0000 In-Reply-To: <1525901216-15031-4-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 9 May 2018 17:26:54 -0400") Message-ID: <8736yz1bbd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fGsZr-001SKL-GN X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:35370 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00266.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> The read_gdb_index_from_section and read_debug_names_from_section Simon> functions read the index content, as their names state, from sections of Simon> object files. A following patch will make it possible to read index Simon> content from standalone files. Simon> This patch therefore decouples the code that reads the index content Simon> from object file sections from the code that processes that content. Simon> Functions dwarf2_read_gdb_index and dwarf2_read_debug_names receive Simon> callbacks that are responsible for providing the index contents (for Simon> both the main file and the potential dwz file). This callback style makes the code harder to read and understand; but other than that this seems fine. Tom