From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33705 invoked by alias); 2 Mar 2018 12:29:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33694 invoked by uid 89); 2 Mar 2018 12:29:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Mar 2018 12:29:02 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 678ED4022909; Fri, 2 Mar 2018 12:29:00 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03BCC10FFE6B; Fri, 2 Mar 2018 12:28:59 +0000 (UTC) From: Sergio Durigan Junior To: Yao Qi Cc: GDB Patches , Simon Marchi , Pedro Alves , Joel Brobecker , Christophe Lyon Subject: Re: [PATCH] Conditionally include "" on common/pathstuff.c (and unbreak build on mingw*) References: <20180301202005.11563-1-sergiodj@redhat.com> <86a7vq4trr.fsf@gmail.com> Date: Fri, 02 Mar 2018 12:29:00 -0000 In-Reply-To: <86a7vq4trr.fsf@gmail.com> (Yao Qi's message of "Fri, 02 Mar 2018 11:11:04 +0000") Message-ID: <87371i7jas.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00055.txt.bz2 On Friday, March 02 2018, Yao Qi wrote: > Sergio Durigan Junior writes: > >> Introduced a regression when compiling for mingw*: >> >> /gdb/common/pathstuff.c: In function 'gdb::unique_xmalloc_ptr >> gdb_realpath(const char*)': >> /gdb/common/pathstuff.c:56:14: error: 'MAX_PATH' was not declared in this scope >> char buf[MAX_PATH]; > > Fedora-x86_64-w64-mingw32 catches this build failure > https://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/1113/steps/compile%20gdb/logs/stdio > but it doesn't send notification on build failure. Could you change the > buildbot config to send notification on build failure? The same as > other builders do. Yeah, it's on my TODO list. I've also noticed this after Christophe reported the failure. Thanks, Yao. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/