From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4171 invoked by alias); 14 Dec 2017 20:31:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4147 invoked by uid 89); 14 Dec 2017 20:31:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Dec 2017 20:31:42 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 616807EA91; Thu, 14 Dec 2017 20:31:41 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9300A7DF5D; Thu, 14 Dec 2017 20:31:39 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , Tom Tromey , Eli Zaretskii , Simon Marchi , Keith Seitz Subject: Re: [PATCH v6 2/2] Implement pahole-like 'ptype /o' option References: <20171121160709.23248-1-sergiodj@redhat.com> <20171214024816.29629-1-sergiodj@redhat.com> <20171214024816.29629-3-sergiodj@redhat.com> <1db3626e-95b3-45b2-2e2e-dc27e97dda16@redhat.com> Date: Thu, 14 Dec 2017 20:31:00 -0000 In-Reply-To: <1db3626e-95b3-45b2-2e2e-dc27e97dda16@redhat.com> (Pedro Alves's message of "Thu, 14 Dec 2017 14:19:26 +0000") Message-ID: <87374dgifo.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00357.txt.bz2 On Thursday, December 14 2017, Pedro Alves wrote: > Something broke in v5 -> v6 in the offset and hole computation. Thanks for catching this. Indeed, the way the offset_bitpos is propagated has changed, and the patch is wrongly calculating it before printing inner fields of structs/unions. I've fixed the logic and now the behavious is back to the old one. All the tests that were passing before are still passing now, which means that I wasn't testing this specific scenario. For that reason, I've added one more test to cover this. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/