From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c
Date: Thu, 19 Oct 2017 21:57:00 -0000 [thread overview]
Message-ID: <87376essvj.fsf@tromey.com> (raw)
In-Reply-To: <877evqssw5.fsf@tromey.com> (Tom Tromey's message of "Thu, 19 Oct 2017 15:57:14 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Maybe an opportunity to std::move? Alternatively:
Simon> holders.emplace_back (string_printf ("group:%s", group_ptr[i]));
Simon> group_ptr[i] = holders.back ().c_str ();
Tom> I made this change. Thanks for noticing this.
Oops, I meant to say, I made the std::move change.
Tom
next prev parent reply other threads:[~2017-10-19 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 4:06 [RFA 1/3] Remove cleanups from prepare_execute_command Tom Tromey
2017-10-18 4:06 ` [RFA 2/3] Remove cleanup from call_function_by_hand_dummy Tom Tromey
2017-10-18 4:06 ` [RFA 3/3] Remove cleanups from break-catch-syscall.c Tom Tromey
2017-10-19 21:00 ` Simon Marchi
2017-10-19 21:57 ` Tom Tromey
2017-10-19 21:57 ` Tom Tromey [this message]
2017-10-20 20:26 ` Simon Marchi
2017-10-25 4:42 ` Tom Tromey
2017-10-25 10:38 ` Pedro Alves
2017-10-25 14:50 ` Tom Tromey
2017-12-06 18:58 ` Sergio Durigan Junior
2017-12-06 21:41 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87376essvj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).