From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix jit-reader.h for multilib
Date: Sun, 11 Jan 2015 12:02:00 -0000 [thread overview]
Message-ID: <87387htths.fsf@codesourcery.com> (raw)
In-Reply-To: <20150107173634.GA13295@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 7 Jan 2015 18:36:34 +0100")
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> I got reported jit-reader.h is not multi-lib safe:
>
> --- /usr/include/gdb/jit-reader.h on x86_64 2015-01-07 11:54:27.705802129 -0500
> +++ /usr/include/gdb/jit-reader.h on i686 2015-01-07 11:54:46.853774165 -0500
> @@ -56,7 +56,7 @@ extern "C" {
>
> /* Represents an address on the target system. */
>
> -typedef unsigned long GDB_CORE_ADDR;
> +typedef unsigned long long GDB_CORE_ADDR;
>
> /* Return status codes. */
>
>
> multi-lib safety means that files with the same pathname (which is
> /usr/include, contrary to /usr/lib vs. /usr/lib64 for example).
Hi Jan,
I am sorry I can't understand what you mean here, can you elaborate?
Do you mean sizeof (GDB_CORE_ADDR) should be the same on different
multi-lib (i686 vs x86_64)?
--
Yao (齐尧)
next prev parent reply other threads:[~2015-01-11 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 17:36 Jan Kratochvil
2015-01-11 12:02 ` Yao Qi [this message]
2015-01-11 13:14 ` Jan Kratochvil
2015-01-12 2:33 ` Yao Qi
2015-01-12 8:42 ` Jan Kratochvil
2015-01-12 9:57 ` Joel Brobecker
2015-06-03 19:42 ` ping: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87387htths.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).