From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8114 invoked by alias); 11 Jan 2015 12:02:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8091 invoked by uid 89); 11 Jan 2015 12:02:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 Jan 2015 12:02:49 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1YAHED-0007NU-45 from Yao_Qi@mentor.com ; Sun, 11 Jan 2015 04:02:45 -0800 Received: from GreenOnly (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Sun, 11 Jan 2015 04:02:44 -0800 From: Yao Qi To: Jan Kratochvil CC: Subject: Re: [patch] Fix jit-reader.h for multilib References: <20150107173634.GA13295@host2.jankratochvil.net> Date: Sun, 11 Jan 2015 12:02:00 -0000 In-Reply-To: <20150107173634.GA13295@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 7 Jan 2015 18:36:34 +0100") Message-ID: <87387htths.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00270.txt.bz2 Jan Kratochvil writes: > I got reported jit-reader.h is not multi-lib safe: > > --- /usr/include/gdb/jit-reader.h on x86_64 2015-01-07 11:54:27.705802129= -0500 > +++ /usr/include/gdb/jit-reader.h on i686 2015-01-07 11:54:46.853774165 -= 0500 > @@ -56,7 +56,7 @@ extern "C" { >=20=20 > /* Represents an address on the target system. */ >=20=20 > -typedef unsigned long GDB_CORE_ADDR; > +typedef unsigned long long GDB_CORE_ADDR; >=20=20 > /* Return status codes. */ >=20=20 > > multi-lib safety means that files with the same pathname (which is > /usr/include, contrary to /usr/lib vs. /usr/lib64 for example). Hi Jan, I am sorry I can't understand what you mean here, can you elaborate? Do you mean sizeof (GDB_CORE_ADDR) should be the same on different multi-lib (i686 vs x86_64)? --=20 Yao (=E9=BD=90=E5=B0=A7)