From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/Python] Fix int() builtin with range type gdb.Value objects.
Date: Wed, 20 Nov 2013 17:25:00 -0000 [thread overview]
Message-ID: <8738mrjchi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20131120024752.GJ3481@adacore.com> (Joel Brobecker's message of "Wed, 20 Nov 2013 06:47:52 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I missed that, you're right! New patch attached.
Joel> gdb/ChangeLog:
Joel> * python/py-value.c (is_intlike): Delete.
Joel> (valpy_int): Replace use of CHECK_TYPEDEF and is_intlike
Joel> by use of is_integral_type.
Joel> (valpy_long): Replace use of CHECK_TYPEDEF and is_intlike
Joel> by use of is_integral_type and check for TYPE_CODE_PTR.
Joel> Re-tested on x86_64-linux, JIC.
Not sure if you are waiting for me, but just in case, this looks good --
thanks for cleaning this up.
Tom
next prev parent reply other threads:[~2013-11-20 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 11:37 Joel Brobecker
2013-11-18 16:52 ` Tom Tromey
2013-11-19 4:10 ` Joel Brobecker
2013-11-19 15:09 ` Tom Tromey
2013-11-20 2:52 ` Joel Brobecker
2013-11-20 17:25 ` Tom Tromey [this message]
2013-11-20 17:28 ` pushed: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738mrjchi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).