From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 381A3385DDD7 for ; Tue, 11 Jun 2024 19:52:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 381A3385DDD7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 381A3385DDD7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718135569; cv=none; b=AxIW05WQilLJ2cK/+v6+GaUevs6czZ+zoBoRRzPNmBlxA6EdVbZD2essslD1nMyWlAoiMhSvqjG5hWk9Y8LJUFyI/cb6ybl99UlJuF7S1RXvh0Zm/27fAxG+dbqfgESTG1axekTliXkYfJ9IzVlpTmwxgcM2otd6XwgOQsUYsL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718135569; c=relaxed/simple; bh=9PrYHj8Pl264wCntt6ts92XLGunzKmdNH6aHMBD2u/M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iybbuJEeRhHQq7+0IaqMHeaoqaICV+g9Z8HiqpCOHvcfDVmQlUVTSD4CzA8OeQ5FtDN7sWz5B8g2RYOpV5gWFI8AiLmV8RXMiygChlQIHN+tij4Sz8ScXeozaqaWrQyl9HWf8zGsmUJj8ehI2Fix9cjLu8O27umFcVoEtI2H+HI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718135567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9PrYHj8Pl264wCntt6ts92XLGunzKmdNH6aHMBD2u/M=; b=QYWJ/nLe5JZk6l6vsVXnV8r0a4PLzTnlakvimTOJzrehDL116xXb+t8JTK7X+DAUdRzMUu Zo+dqfsaiqQDbhMgOfFAfH2vpAxirvWOK99gv+YQ2PwvsxizHYOOtHh6quBeWxes0uy8rd b704b1jXzUXpCLLrXVb1CMthKXjvw9s= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-4zNwqZnqN4ukBxaYaC6nsw-1; Tue, 11 Jun 2024 15:52:45 -0400 X-MC-Unique: 4zNwqZnqN4ukBxaYaC6nsw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-35f1cfa0be9so1804342f8f.2 for ; Tue, 11 Jun 2024 12:52:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718135564; x=1718740364; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9PrYHj8Pl264wCntt6ts92XLGunzKmdNH6aHMBD2u/M=; b=TNlHfmts562ny5tTReNnHS1MdGx7DEi90NDsRCBEq7GnHLTFf770apI8CKfr+Sn4Jv VQ9UjwgSmKYQ86MEzt8wPuVzomtcvuLUwQR3FlG1JmMrLiOwOGrjpkcVtsyvHRZBx4gA dJ1GQgIPEKspRby/oIxA67pcHGOyCTM3XF0LkkuPPt+Kk5WWzXEeyZZExtWoIGXeQL2V ydBNzuCr/I61cQsZolRjcLqgbeDsoBbX/L/ro1OmnAkI5EJnHqzgBieMG4Q18yPdN8dx MWJ6RlJ8b+i6snOBg5RaMtspaGJ6zjItXy2KtzEGQl6Qy2pl8pSMU29CLLjtWBNmfpE0 IhOw== X-Gm-Message-State: AOJu0YzHjAmaCVZjuk2xK2O/FMiBgGcmTqGvRuUnFCaj5f+wfKETD+8/ ZKhpfN5epTq/0ru8cUmHRMfsmfTDb0NdKV7CDdGYOBRMnR2LBt62zOU+ywjJkxrkvYn3PFD4jUr X9qjJUUFCO9PUxkRGUECHbcqd9SDx7Y6l2Lob6wLUc41F9BeSRzMEfF4J1MRwoU6WJNk= X-Received: by 2002:a5d:64ea:0:b0:35f:30bb:c314 with SMTP id ffacd0b85a97d-35f30bbc389mr1066128f8f.39.1718135563796; Tue, 11 Jun 2024 12:52:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG39ddD8N4HaafUSbGb3Z3sO0tb3Xi2+AFPOTRoBN5xq9NRi/skwc5FAsEEDMR5gyOItcJoag== X-Received: by 2002:a5d:64ea:0:b0:35f:30bb:c314 with SMTP id ffacd0b85a97d-35f30bbc389mr1066116f8f.39.1718135563366; Tue, 11 Jun 2024 12:52:43 -0700 (PDT) Received: from localhost ([31.111.84.186]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f29629231sm4400884f8f.67.2024.06.11.12.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 12:52:43 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] gdb: warn of slow remote file reading only after a successful open In-Reply-To: <87frtqm2jo.fsf@tromey.com> References: <275ae278174f9a93d1c40c1d22fce993abb5cc40.1717592684.git.aburgess@redhat.com> <87frtqm2jo.fsf@tromey.com> Date: Tue, 11 Jun 2024 20:52:42 +0100 Message-ID: <874j9z9rzp.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> So, in remote_target::remote_hostio_open(), I'd like to move the block > Andrew> of code that prints the above message to after the open call has been > Andrew> made, and we should only print the message if the open succeeds. > > Andrew> Now GDB only tells the user about files that we actually open and read > Andrew> from the remote. > > Makes sense to me. > Approved-By: Tom Tromey Pushed. Thanks, Andrew