Re: [PATCH] [gdbserver] Imply --once if connecting via stdio

[Andrew Burgess <aburgess@redhat.com>]

William Ferreira <wqferr@gmail.com> writes:

> Currently, gdbserver hangs after stdin is closed while it tries to
> write: "Remote side has terminated connection.  GDBserver will reopen
> the connection." This hang disappears if --once is also given. Since
> the stdin connection won't ever reopen if it's closed, it's safe to
> assume --once is desired.

Thanks for working on this.

Ideally it would be nice to have a test added for this.  We already have
gdb.server/server-pipe.exp which uses 'target remote | ...', maybe this
test could be extended?  Or you could copy this test and change it as
needed?

Let me know if you need additional help writing a test.

Thanks,
Andrew


>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29796
> ---
>  gdbserver/server.cc | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index 789af36d9a4..3ab7a1eed14 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -4204,6 +4204,10 @@ captured_main (int argc, char *argv[])
>  	  /* "-" specifies a stdio connection and is a form of port
>  	     specification.  */
>  	  port = STDIO_CONNECTION_NAME;
> +
> +	  /* Implying --once here prevents a hang after stdin has been closed.  */
> +	  run_once = true;
> +
>  	  next_arg++;
>  	  break;
>  	}
> -- 
> 2.45.1