Re: [PATCH] gdb: add gdbarch_stack_grows_down function

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> I propose adding a new function `gdbarch_stack_grows_down`.  This is
Andrew> not going to be a gdbarch method that can be overridden, instead, this
Andrew> will just call the gdbarch_inner_than function.  We already have some
Andrew> gdbarch methods like this, checkout arch-utils.c for examples.

This makes sense to me.

Andrew> +  /* The current assumption is that stacks either grow down, or they grow
Andrew> +     up, so one of these checks should be true.  */
Andrew> +  gdb_assert (gdbarch_inner_than (arch, 1, 2)
Andrew> +	      || gdbarch_inner_than (arch, 2, 1));

I wonder if this would be better as a new all-arch self-test in
gdbarch-selftests.c.

Tom