From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 1D7D2385843B for ; Thu, 9 May 2024 19:43:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D7D2385843B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D7D2385843B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715283827; cv=none; b=XYatqP0SZJInBzFp+WmeelGXddVTlKfBeL4hLALY2kWqMBXzrdiGkhr3/yS31FUII+18dG+7ieBtpflGWhH0iYoNFLZw+7AmyivNR2VFxSDRHuyt0EBpLHWPAAfHlhE6CUNhyrzFtIXPFtFaAheZRr2IRiU/k3ocBWRKoITJ74E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715283827; c=relaxed/simple; bh=PDpC9/kPS8SWJGjx0v0/UgfK7iFYmdEo88WC9EAa5r8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=e4OuSmpzwx5zqHYuYR7qh1n9eNsODJWgUH97Kb7qwwXIad66Svx4KeWptA9v9S0goqG+e0joHaZLsr1JUO8oomcsZlhCqp9/vPob1nClerEfctRdjNskWMukm0HtaUVbpVt2el5JKYotwh4B82p13T4DAi6U+hZYP4Ru7ic6AiY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id 56ghsmicrSqsh59g5sXTRE; Thu, 09 May 2024 19:43:41 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 59fssBbgSuv6X59ftsuQ0z; Thu, 09 May 2024 19:43:29 +0000 X-Authority-Analysis: v=2.4 cv=YbZ25BRf c=1 sm=1 tr=0 ts=663d276c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=TpHVaj0NuXgA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=hLbxFyl3pctVkaP3WHEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=55u84egXF4wUTHHa7al+svq7m1o+L2F4KOrf+aTVBl8=; b=pBbhp5G9EDPFz/6ogfWzwfUnDq sew1VCnofrL4sL6MXBzWveckb4VKcDAYIrjKXrnceaH1YL7cCoFmTYKs8+mgxBZoK6vw66GEcPfxn iIukvtPW8YTThcZllxRxiGH1R; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:49028 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s59fs-0040nt-2F; Thu, 09 May 2024 13:43:28 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: add gdbarch_stack_grows_down function In-Reply-To: (Andrew Burgess's message of "Thu, 9 May 2024 15:59:04 +0100") References: X-Attribution: Tom Date: Thu, 09 May 2024 13:43:27 -0600 Message-ID: <874jb63h5s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s59fs-0040nt-2F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:49028 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFUOiMiGJLyALrKPegLdty0jAGpdUkdx1yUAlbpaTI6K1STo/NxP51bX3nBtPdQ5g9w6xVv7wPZecZS9YA5EItHAvhs1c8HC27IzIeq7Hx8xbOODINxK EVmcExOg4h2MFb5qusO316enjKVeW2QhZciWegsAUCfLbXxCq8Er8D9rLiuYCc+QGXGIMa/brpRnvFF4TdlJI6MU1WWSJKSW1XU= X-Spam-Status: No, score=-3014.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> I propose adding a new function `gdbarch_stack_grows_down`. This is Andrew> not going to be a gdbarch method that can be overridden, instead, this Andrew> will just call the gdbarch_inner_than function. We already have some Andrew> gdbarch methods like this, checkout arch-utils.c for examples. This makes sense to me. Andrew> + /* The current assumption is that stacks either grow down, or they grow Andrew> + up, so one of these checks should be true. */ Andrew> + gdb_assert (gdbarch_inner_than (arch, 1, 2) Andrew> + || gdbarch_inner_than (arch, 2, 1)); I wonder if this would be better as a new all-arch self-test in gdbarch-selftests.c. Tom