From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 599AC3858D35 for ; Tue, 30 Apr 2024 03:08:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 599AC3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 599AC3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714446494; cv=none; b=x+wao+L9hRYyqC5Pk1WaeYovkKNgv3laSwfVAfPPS77bnQTGbBJYPtm8wXQGVSpn3wDqnm6BGyEa+W0oCDXoB6l9zAORqo+7DYTZnY9c7rALpdpeWKN4OJlge6HooSCP9zQS9OyHCAaGmI9CBUxG2S8W9hb+aO/lqnEd7kuFzjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714446494; c=relaxed/simple; bh=++gD/OzvEd4nPogjXA/WiJL+GHwBctbFUuIYWHl3bG8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HmGFg6gyUZNtycxAmvmWrosGwSrm9xBw07WnniCSmi5JlFiaueWTt6Tn44LH7bDRYSeu3jGXPpTy5ejhmojJiX3vxcpNsqOjWMjGjbciET6OP9dI0IYp+vCb+ynQ+6YV+bfsTpGLuc5G7x1DjHwX0g/DTAcRMNuCY13hPdzDXCI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-23333ef4a02so2594934fac.1 for ; Mon, 29 Apr 2024 20:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714446490; x=1715051290; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=14/rXsXxGGEQtRKxZyeNDd8A+fRffF+dx0MGCfzMk1M=; b=djN37Y78qIq3Yilr/tnnpHAo0TCV4RQuUQ3L4fk8SUZE1hLl6iqO3wrhsbmyGGF555 zXO7m6pGeo9+hfAB8/30DnObdy7Y5je2mqC9E6yubj3EKmh2aNyr9RGdK7gXwO0KnybJ RqfcchGcAgptTUGnE74zQdrm2TWDHO0gqWwP+Xw2Al4QB5ERDtodz4og6/Dnt3nlHuk5 8tM8JR5kmvT4IwIJisVxke+X/CeZY81IG+P4PcAyFXwMOI8gqm1qQOAknaKAR0M6OENW 8v8CmCWtwDhsvgpTbmHW/YGhbPUyQe5Xe2/sg5c9d6aF+RhKdA/k302hrt+zTB8sN3hd Zttw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714446490; x=1715051290; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=14/rXsXxGGEQtRKxZyeNDd8A+fRffF+dx0MGCfzMk1M=; b=BIUI+T8VAzoaVG/YIqGnUQ3n11g3XTtyL5muMcAAWmK24S5tGVlatMIWWkVUZq33pj nrL4euF8q0RvdfkfKSIBz56SSPjEcfE8OpAKBa9fDVjzre/8Z1F6/EpbtuSM0agNj9pQ yRRHhGEc21eDN0nXmL+0JcjWN8PCQwYUeN/VA5InM/e06sCDUFBPRqeDsARiRbxoccn7 4WAaR1nvkG7eif0cgUjQPI2gb1Vz2sk/j6L+hxZ9b2oS5+KEm2VFW2tONTosDl7prtYC xN3cNuQGvB/VIBFWUKBNRsAJjRcatvPMzhvE85LAKgVYbizadh2pRb2jp/7Vn4kFjRXU 8+Ng== X-Gm-Message-State: AOJu0YwziwvGiMuqXalmceAwrzk+REEXqraPiEkSMeKzIIb5+hfcX3xw yGWjDjjBPU88XPyPKfl+SmPGz0YqEUOKoJpUwzQaytKEAY4p2MGZ3NSYiw3OeJY= X-Google-Smtp-Source: AGHT+IGoOXcVr0FcVCXJDKYddoyEqHXaAtt3W51VW2Wb6N63ydUlC6lDpdWcMnWjWgDBGgW10wfCsQ== X-Received: by 2002:a05:6870:224f:b0:23c:ad86:9935 with SMTP id j15-20020a056870224f00b0023cad869935mr4896661oaf.45.1714446490637; Mon, 29 Apr 2024 20:08:10 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:3d56:74b5:22f4:1590]) by smtp.gmail.com with ESMTPSA id 17-20020a056a00073100b006eadc87233dsm20021063pfm.165.2024.04.29.20.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 20:08:10 -0700 (PDT) From: Thiago Jung Bauermann To: Kevin Buettner Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH v4] gdb/testsuite: Add gdb.base/memops-watchpoint.exp In-Reply-To: <20240425194449.79797d27@f39-zbm-amd> (Kevin Buettner's message of "Thu, 25 Apr 2024 19:44:49 -0700") References: <20240426014626.1668298-1-thiago.bauermann@linaro.org> <20240425194449.79797d27@f39-zbm-amd> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Tue, 30 Apr 2024 00:08:07 -0300 Message-ID: <874jbjzgx4.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Kevin, Kevin Buettner writes: > On Thu, 25 Apr 2024 22:46:26 -0300 > Thiago Jung Bauermann wrote: > >> Test behaviour of watchpoints triggered by libc's memset/memcpy/memmove. >> These functions are frequently optimized with specialized instructions >> that favor larger memory access operations, so make sure GDB behaves >> correctly in their presence. >> >> There's a separate watched variable for each function so that the testcase >> can test whether GDB correctly identified the watchpoint that triggered. >> >> Also, the watchpoint is 28 bytes away from the beginning of the buffer >> being modified, so that large memory accesses (if present) are exercised. >> >> PR testsuite/31484 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31484 >> --- >> >> Changes in v4: >> - Also accept memmove symbol for memcpy watchpoint test (Suggested by Kevin). >> >> Changes in v3: >> - Reworked "continue until memset/memcpy/memmove watchpoint hits" tests to >> have a chance to work even without libc debug info (Suggested by Kevin). >> - Dropped "require libc6_has_debug_info" call (Suggested by Kevin). >> >> Changes in v2: >> - Ensure watchpoints are aligned to 4 bytes. >> - Add kfail for arm-linux. > > LGTM, plus I didn't find any problems while testing on Fedora 39 x86_64, > both with and without debuginfo. Thanks for testing. > Approved-by: Kevin Buettner Thank you! Pushed as commit 6b4b601b35a0 ("gdb/testsuite: Add gdb.base/memops-watchpoint.exp"). -- Thiago