From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 2/3] gdb: wait for inferior after attaching instead of adding a continuation
Date: Fri, 19 Apr 2024 14:33:06 -0600 [thread overview]
Message-ID: <874jbxt7nh.fsf@tromey.com> (raw)
In-Reply-To: <dacc536cd44bf7556e86db013ae665b38e7b5d01.1713423838.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur's message of "Thu, 18 Apr 2024 09:36:37 +0200")
>>>>> "Tankut" == Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
Tankut> In a less harmful case, the current implementation causes an unnatural
Tankut> positioning of the GDB prompt in a single target setting when
Tankut> executing the attach command in async mode using the '&' operator.
I'd prefer Pedro review this, since he's the infrun expert, but I was
curious about this point -- it seems to me that "attach &" should be
expected not to wait.
So maybe the issue is that somehow a continuation is being run for the
wrong inferior? Like in this part of the final patch:
- /* Do all continuations associated with the whole inferior (not
- a particular thread). */
- if (inferior_ptid != null_ptid)
- current_inferior ()->do_all_continuations ();
... do inferior_ptid and current_inferior disagree here?
Or else why does this code get invoked?
Tom
next prev parent reply other threads:[~2024-04-19 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:36 [RFC 0/3] Wait for inferior after attaching Tankut Baris Aktemur
2024-04-18 7:36 ` [PATCH 1/3] gdb: print target in print_target_wait_results Tankut Baris Aktemur
2024-04-18 7:36 ` [RFC 2/3] gdb: wait for inferior after attaching instead of adding a continuation Tankut Baris Aktemur
2024-04-19 20:33 ` Tom Tromey [this message]
2024-04-22 6:48 ` Aktemur, Tankut Baris
2024-04-18 7:36 ` [RFC 3/3] gdb: remove inferior continuations Tankut Baris Aktemur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jbxt7nh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).