From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdbserver/linux: probe for libiconv in configure
Date: Thu, 14 Mar 2024 09:44:56 -0600 [thread overview]
Message-ID: <874jd8lsw7.fsf@tromey.com> (raw)
In-Reply-To: <20240301152716.13929-1-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 1 Mar 2024 10:27:04 -0500")
>>>>> Simon Marchi <simon.marchi@efficios.com> writes:
> Changes in v2:
> - Add dependencies on (in-tree) libiconv in top-level build system.
> - Minor rewording of comment to make it clear that libiconv is a hard
> requirement for Linux hosts and unused for other hosts.
Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-03-14 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:27 Simon Marchi
2024-03-14 15:44 ` Tom Tromey [this message]
2024-03-14 17:42 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jd8lsw7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).