From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id D25C43858D28 for ; Mon, 4 Mar 2024 18:40:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D25C43858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D25C43858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709577651; cv=none; b=PwdR4vXbLSO53vPKWmzsoDnX9sWtWYR18qCNWW2ir5eQhYcXq0Y2YjijrhUb8XtcUibNY8873vMqYgJoVFyDTJTFqFLPBPNYYTmTNxhhAuWTgvBwPOYS//ukgerGvSqE+sjF2LhTlwE6lIJnrHK5c8V6wCodaBAuOhLOxcmHuRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709577651; c=relaxed/simple; bh=MI1H9SslvwuCkDXhTkvEkxazajCKxS/aXVJAHgQYvFA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=E5OJjA1BS5reUe0M1OQF0vQDGMOSe3gpYrhef95bskOFqPs9VYZrvwlPJDBeshZFNXAfkP4fIMFd6Ofvw9CD8spAZkfzHDRCeC5Y0MNgkGmK1UmHhfpDAc+AUkOxmb3CEr+C+f0lo8MACLVr6YODQM5j5cvmRzYAGJ/xjgWcbZw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id hBYsraepWHXmAhDF1r7A1E; Mon, 04 Mar 2024 18:40:47 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id hDF0rwYRL2Ka4hDF0rSakv; Mon, 04 Mar 2024 18:40:47 +0000 X-Authority-Analysis: v=2.4 cv=JvP3rt4C c=1 sm=1 tr=0 ts=65e615af a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=8AHkEIZyAAAA:8 a=jHtzENzRaS7kfTn-GzgA:9 a=-mJCUOJyassA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TYEZGbZoYvrTp31I4mY6Amrn9i2xkoh0CJ5blQj+DZY=; b=ufn8r+Pz10rRGTuaAt6j55N0vA Qp6DnyWxgO2zjK5L2lCy7yrDRh8UbkUBih4R8C9LniRGtFq/fzbyZy8yA+9ywPz+vu+W1YsnuLMvj ltdhMwsJVo51yZCYUj/D6t8f1; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:59626 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rhDF0-004N3D-0c; Mon, 04 Mar 2024 11:40:46 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] [gdb/python] Handle normalized exception returned by PyErr_Fetch References: <20240304160347.31182-1-tdevries@suse.de> X-Attribution: Tom Date: Mon, 04 Mar 2024 11:40:45 -0700 In-Reply-To: <20240304160347.31182-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 4 Mar 2024 17:03:46 +0100") Message-ID: <874jdlu9g2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rhDF0-004N3D-0c X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net (murgatroyd) [71.211.170.195]:59626 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAUqhaIeU6FHcJ80EBI7SA8lbwUa5iehUEefyu9fq2k8aB/VMMzLcQgkPDqL5I4Bdss1wY7JHZV431jKIsjoDBa5j50Fes+YuQ/vrgERKvi8+s9UeBsP JfOunwtP4aKK1NBUq4nuvhOLtPvucYnFCIRh8nZkIq95hYDa0uSUwVJos1Ur+1F6M/5BTkuKW0DgOetWyCIhq/fjjvht92BonzY= X-Spam-Status: No, score=-3016.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> + /* Detected a normalized exception. */ Tom> + PyObject *args = PyException_GetArgs (m_error_value.get ()); According to: https://docs.python.org/3/c-api/exceptions.html ... PyException_GetArgs returns a new reference; so this code leaks memory. I think args should be a gdbpy_ref<> here. Tom