From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id 87FB03858D20 for ; Tue, 20 Feb 2024 14:08:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87FB03858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87FB03858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708438129; cv=none; b=ZxZm9NrDhVzDJQTDve1OA7rQI9Fiq071zc3PyzqnNYCl4G6YfAcX25fb7QVOcTgw4DmqXAshAPgsXaroDPq20s+grrekcAvcCy6NI7rCI20QPVfB8ehX/ZTL0v6BAvp+8bKklAqRthByNrYuBg4jxs6FWarkIUogTzMs44fOUIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708438129; c=relaxed/simple; bh=LQcTrX0FwIUxo4n4tg7Xeu+hF78bK0zc5S60wzlm0Dg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=okXSeDfhYNtf/SfRYDwNoBoIg5I+qUAgkGr1W1GOmjawHD4ac8zDOGlXS02BJ+mrXYZ+IQBV9YHJsiD0eKojob1/FW39rNTiBdnNE3sA6L5FGY3wd+6pNfoJg4thE2cW5PC7CQg9yQXvg5UN1V4/VguQkWxw9RDpOtbSxQCbtHM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7c3e01a7fdeso234517039f.1 for ; Tue, 20 Feb 2024 06:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1708438121; x=1709042921; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KjeJtwo3pz3fIitlMlgm9ZGWP5WXP6dP1dRsAEHwHdE=; b=JlJbCV7gy13JozzqvVn7Gzyty4H0ToTsalMhEaVqODRaMEc7MqzU8V0uyB/tEddenh fYMx4huuJRhm25g5E4pOSFBFBP+PkjN86OPo/KPRAl8F+RJerKq9FTuiLBgHnETPdOCV DnPq58zGWiX6deS3WtCPeYSX/wrEPX7w2hqoTr2+2d0fZTSxxDiub+u7cNDzEsSFgx+0 og3DTtcJtlRP0gVbW0qQzn0TunymFVABnJvi/Et3kGuqOahOM3X7Spp8x98bLMCXBnp+ 11efdiOcikgZhT7/o/qKo26Ebe79JzorKIopb7xkA56BRB0A8yYtKflF8rnUJaEHae3a eBWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708438121; x=1709042921; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KjeJtwo3pz3fIitlMlgm9ZGWP5WXP6dP1dRsAEHwHdE=; b=KcKrzKOz6/YHC2rgJuSnRi4QNbfqXF77qFYSPsmUGMmKSSyM24t6Nfg0PCAYrwmF8t 9iamxtMTmsJMIjL8y9vo9z7fs0AIdjDaIa5OHwJGwYIctFOdf4JULvjZAEASqG79ib4U r1Ekaid/kadH9AUAjW2/unTaPEz6sRNJj3VwJriAPCjsfVLhhiz9xQTHsJN+IAG4MZmP oUiUoTpizYXi6HXqYCIcTRp+c65PqTecuNam6snFg43ej7igXcfmHQ650dnAhIkpDPxJ egQJCWtz9PVDrZhsaiFurNqNKrlJY9RO5G3KYXnfhql5cR0Rrb7hg+ry+gK2kvHAceCf z+Fw== X-Forwarded-Encrypted: i=1; AJvYcCVDhwg+pXzk5vhwozyv4ddlAosO/0lOqnvpGMSmrSHcBn20xXunBw++VCciW91UdGeTB+cR2MmG8OyYsA7Ml8L1YP2rhSi9knTrVQ== X-Gm-Message-State: AOJu0YzQ9gHEowjv3YEB6evbTvQw4eKYao0330KotSqe4OxZ6mxdCDss 664tQzk3SkgQWMZUR5ZkQIlioejtHwVnVjPQJZwaZGL0Wb9hIzNflMC4Woh+0A== X-Google-Smtp-Source: AGHT+IFZEIC4FcuiM4l2vqsRa5Cl8ohpZ981Rs/8LMjB89oTeOnVhqiHrsguXg1PydXuqsqv/t5YrA== X-Received: by 2002:a5d:8e01:0:b0:7c7:247e:34c7 with SMTP id e1-20020a5d8e01000000b007c7247e34c7mr13484644iod.9.1708438121599; Tue, 20 Feb 2024 06:08:41 -0800 (PST) Received: from murgatroyd (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id t125-20020a6bc383000000b007c4926ebed8sm2399584iof.40.2024.02.20.06.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:08:41 -0800 (PST) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] Introduce new overload of read_text_file_to_string References: <20240216-py-simple-exc-v1-0-c275bcfb5e4a@adacore.com> <20240216-py-simple-exc-v1-1-c275bcfb5e4a@adacore.com> <01e650fd-3a6c-4e2b-bf17-d0e89f19070b@suse.de> X-Attribution: Tom Date: Tue, 20 Feb 2024 07:08:40 -0700 In-Reply-To: <01e650fd-3a6c-4e2b-bf17-d0e89f19070b@suse.de> (Tom de Vries's message of "Mon, 19 Feb 2024 16:36:34 +0100") Message-ID: <874je3449j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> On 2/16/24 19:37, Tom Tromey wrote: >> +/* Read the entire content of FILE into an std::string. */ >> + >> +extern std::string read_text_file_to_string (FILE *file); >> + >> #endif /* COMMON_FILESTUFF_H */ >> Tom> It occurred to me that if this reads the entire content of FILE, Tom> shouldn't it start with an "fseek (file, 0, SEEK_SET)"? Tom> We could add an argument at_start that lets us skip the fseek, and Tom> default it to false, and call it with at_start set to true from the Tom> "const char *path" version of read_text_file_to_string. I'd rather not add things that we don't need. How about I rename the function instead? Tom