From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 074F43858C2C for ; Wed, 3 Jan 2024 09:39:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 074F43858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 074F43858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704274785; cv=none; b=LPRWAV6b7D0HVpf5aG7Cmlq/sPcWdZIzfZjf3CnjGjB3Y1aM93U0Q5L8LWQ3l7yeEwwG5l3b5WbLYIeIW2l8G3yFMRgLlM0xHMrxIbAh+Mfj4xOdXl1I13WuodyWl1VQXkgd9skhFYc4ml5MVRJMmedZgU/NRmEzwVp+m/47iP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704274785; c=relaxed/simple; bh=p/UVWroUgh1kI91V5XDJtgoNBoWCnoN1xaypeq7Xz5s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SYrc+IRYYi8RAQ9PkErya946/Jf7plVlYSaze8Ff1WHaftunP0a2nGFTdxL42Q+PUnDr7QZz76o8fVN3Y6wk12nAB3izQ2pA/JYgIvrXjTb3hindu9m9iHwX/RtyC9omz0W+GogtQrWu6DBNVd3k7GMyUtQ3p+GXR/aMbR2h7EA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704274780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyh+b8xy+YoPSExdhdlQluZjaO5f0HiQoffbvlleMVY=; b=Qgd9cEUVR2rqaNNsGjEl3UkHKr3oiFtZ3dkwdcJXlpecbmxIXXqCN/m2apZMc7EpH1rnKX t4vhLxJWwXSdRlfDo3N0eZc0d2GHHN04t1qDD4/DKt+Hvi9orgKtJ+hQWYBRTOE57CE9+8 WS1CGSVcLF0qRaI+/fp2+pfpUw+QHwI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-h_uqZ-ULNSCWIPpV53zjQQ-1; Wed, 03 Jan 2024 04:39:38 -0500 X-MC-Unique: h_uqZ-ULNSCWIPpV53zjQQ-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5560cd16f03so1577585a12.2 for ; Wed, 03 Jan 2024 01:39:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704274776; x=1704879576; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3j7oZC5iDvkIMYmTwt9oIZl0qosXGrg+Pgkz9sbKFxg=; b=P7le33CuLHtdcYip4otG1gMXImED0jDmg7zKIVt8EImha5vBo5f2p9KqRyGxVocvLq 2pHcMCOcHAACUYQAyTvBpDoGHPktZz1JJK0n2EmWazdZfIoEsu3XPcIVMmbdU/OdL4Zd 10md5fQt4x3Rnm8A8O0OMwYM0Dx3+RLX1WN07gjHj5ofbZXq1YT7OSCAQOwT6qqvgljQ zRR49JPsfUAq9iGzteH6ZnTFkbU3in9R/yNotEsVeC7dVYuPXo6o8VbFkx69OLAWTnOH sfrAxpbSkA5xncxLSjGp4mYAy6amgH4snd7bH+pj20W0w6mhA0soMxrsxl8DEOIGjL/w WYvg== X-Gm-Message-State: AOJu0YzWBHdtOXi+0wYFwRBzo0fxxEMhft5XKHzzQkqcfgJUaiPb0AfF +AkGkjPGkE+nmwpsXKSibZU937oi6w/SO812W1jkniH/JeIXaSLyytY0s2ElOEs4hdimmFReJkW JGda3AfPeZ+v8TKvFadGoC1Yq2Y3qlmyxrZ9brg== X-Received: by 2002:a17:906:7484:b0:a23:54d8:e6ea with SMTP id e4-20020a170906748400b00a2354d8e6eamr8801578ejl.37.1704274776732; Wed, 03 Jan 2024 01:39:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEu4j0bbKwjxVi/v4kdIJIr3hFIStMpt95VJ6fnL1o2yPZ6m2bhg54Nw2Z6jFU6/A2fYuHRdw== X-Received: by 2002:a17:906:7484:b0:a23:54d8:e6ea with SMTP id e4-20020a170906748400b00a2354d8e6eamr8801574ejl.37.1704274776441; Wed, 03 Jan 2024 01:39:36 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id eu18-20020a170907299200b00a26e53be089sm9355022ejc.44.2024.01.03.01.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 01:39:36 -0800 (PST) From: Andrew Burgess To: Lancelot SIX Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 2/3] gdb: merge error handling from different expression parsers In-Reply-To: <20240102150142.43m4ycd7thwezwe3@octopus> References: <06889e172a22e80af44b30b1e70f1f06ecb3ba96.1704206350.git.aburgess@redhat.com> <20240102150142.43m4ycd7thwezwe3@octopus> Date: Wed, 03 Jan 2024 09:39:34 +0000 Message-ID: <874jfuah7t.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Lancelot SIX writes: > Hi Andrew, > > Just a nit below > >> diff --git a/gdb/parser-defs.h b/gdb/parser-defs.h >> index 93ebdf5c061..4d40245228b 100644 >> --- a/gdb/parser-defs.h >> +++ b/gdb/parser-defs.h >> @@ -262,6 +262,11 @@ struct parser_state : public expr_builder >> push (expr::make_operation (std::move (lhs), std::move (rhs))); >> } >> =20 >> + /* Function called from various the various parsers yyerror functions= to > > I=E2=80=AFthink the first "various" came from some previous wording and s= hould > be dropped. Fixed locally to: /* Function called from the various parsers' yyerror functions to throw an error. The error will include a message identifying the location of the error within the current expression. */ void parse_error (const char *msg); Thanks, Andrew > > Best, > Lancelot. > >> + throw an error. The error will include a message identifying the >> + location of the error within the current expression. */ >> + void parse_error (const char *msg); >> + >> /* If this is nonzero, this block is used as the lexical context for >> symbol names. */ >> =20 >> --=20 >> 2.25.4 >>=20