Re: [PATCH 0/6] Add vDefaultInferiorFd feature

[Tom Tromey <tom@tromey.com>]

>>>>> "Alexandra" == Alexandra Hájková <ahajkova@redhat.com> writes:

FWIW I tend to think Pedro ought to review this, since he's got the most
up-to-date experience with terminal handling, etc; or at least more so
than I do.

I do have a few comments on the implementation, but before that, I
wanted to ask a bit about the overall approach.

Alexandra> Currently, when GDBserver is run locally using stdio, the inferior
Alexandra> is unable to read from STDIN so we can't give it any input.

This idea in general seems fine to me (pending Pedro's input).
It's also in line with, and probably needed by, the idea of moving gdb
to a "gdbserver-only" model:

https://sourceware.org/gdb/wiki/LocalRemoteFeatureParity

It's never been super clear to me if gdbserver-only is a real goal or
just something we talk about idly.  I've been on the fence about it
myself, though more recently I tend to like the idea, simply because it
means less work -- I've written a number of patches now that needed work
on both gdb and gdbserver, and this project would halve that kind of
effort.

Alexandra> Add a new DefaultInferiorFd feature and the corresponding packet.

One question I had is - why a new packet?  A new packet seems somewhat
weird, in that it's only valid pretty early during startup, it seems.

Another approach might be to have a different way to specify the
connection fd to the remote, like a command-line option naming the fd to
use for RSP traffic.

Tom