From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 66A20384F985 for ; Thu, 30 Nov 2023 19:26:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66A20384F985 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 66A20384F985 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372374; cv=none; b=Ml3aI8P4Hp1FukVDzZnYBSFm+dPwAC86yKGCs1ckxOEqVnpbCmo6WvPElJwt2+6p/PMeRGfVAcKL9vF+KGhw2fZrjQhkuJYL32jGn2h2S4R9THLO0B9cAKWgCEel1BEwQyZNxOKQJVICDV8ev1jsRP9pc0zznuZfA8Wsrt37Cz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372374; c=relaxed/simple; bh=tCyotSO8iCCLUHwfJrdh2H6FGJ/FX/Os97ebeP6Nff0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aKtkz3JRLPwLPE+2gFFZKqJLnYKwVEbuYyRTOZz37VuVk7AQYzhnZiyEq8JP2//ZebFjMTeqs8niSd1rXGLcabIZs7/M/MfEUH0szgq1qmhWeiHKeB0cm8SL1HZU5gwrqkMqJMzSxu5EQ/3FOeNvOsGgkuY0ZYRI0CZRH6BS9tQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id 8jefrj2X86nOZ8mftrVqGV; Thu, 30 Nov 2023 19:26:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 8mfrrpwaT11XZ8mfsrI0nr; Thu, 30 Nov 2023 19:26:12 +0000 X-Authority-Analysis: v=2.4 cv=Z+v/oVdA c=1 sm=1 tr=0 ts=6568e1d4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=twQLWW2smplvS2ocSagA:9 a=zgiPjhLxNE0A:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=e/gng3lB1Cs9g34uilJsJ/eJF829J8oaJeJJ/bTA+q8=; b=UnRb3biBbAB1i6N/HNLciYX4Fg a9wT5FTZ2PO+6/JkAV/0KsNQ6a3fr0wLC3TUw2VoptIPuOCFpSUSS4+0RwdpQDtm42+24HdP6WEiH luhZq/46oDElsmbgwVzjnz5mM; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:35210 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r8mfr-003ujz-2H; Thu, 30 Nov 2023 12:26:11 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/build] Fix adding -DNDEBUG to python flags of release build References: <20231130112128.9197-1-tdevries@suse.de> X-Attribution: Tom Date: Thu, 30 Nov 2023 12:26:11 -0700 In-Reply-To: <20231130112128.9197-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 30 Nov 2023 12:21:28 +0100") Message-ID: <874jh3cab0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r8mfr-003ujz-2H X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:35210 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMflzxKXLNRYu9Be80jwh4QoFsMFb65/fMAZHkzPuf09U9yGVlfoakFaS0lhcP9j9BAq7td335wktdt8z/oGj5uzKjDixnriQcNLDxanjOACk/d+Sn+G rm6gvJDb9aNIoGCERkI+ZExj1fNaHEOAO+w4Kc8VEtI38OvAflZn45yDwIfnamzo4unUJdHzXO2DyaVl0H+OB2mo0C4N4P88/4I= X-Spam-Status: No, score=-3017.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> [ This was not obvious to me, but apparently evaluating an empty or undefined Tom> variable in this context is similar to using ':' or 'true', so the line is Tom> evaluated as: TIL. Tom> [ Unfortunately, the move might introduce issues similar to the one we're Tom> fixing, and I'm not sure how to check for this. Shellcheck doesn't detect Tom> this type of problem. FWIW, I did run shellcheck (using arguments -xa, in the Tom> src/gdb directory to make sure ../bfd/development.sh is taken into account) Tom> before and after and observed that the number of lines/words/chars in the Tom> shellcheck output is identical. ] I don't think there's a good way to figure this out. It's one of the problems with autoconf. If we do discover an issue, we may have to split the macro in two; or perhaps move more code into it. Anyway I think this is ok. Approved-By: Tom Tromey Tom