From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 7EB583858D20 for ; Tue, 14 Nov 2023 15:39:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EB583858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7EB583858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699976389; cv=none; b=vldrmU0KoRWsiIs/9vGAMwK1Dd5YSyr87ANpgRW+tNIdcSzkPQPvmWv479+cu0yn3T97k1tEqX9xPVqMXnTbERpBjW1s8Desbb7QgqWL1XorK2ppwJlKrLox6zKaGr4s8lc9DpwZ6u1T7Oz0hSjoZfdhvMtfux8HWOC66WDYRyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699976389; c=relaxed/simple; bh=igARYQYXkdX24l2txCXEi23wMiqnan8uRDtHOsqqmiQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UNlNQ3TOojxI62QNbJc4EHjilvBu6DC1VOyHHjgSePs2jZACrxx9GdKmWozIhAHlxvOOD1v7WpVfgGhLevKthhyx0faPLVHdyaOSlV+4iJVIpDAaSHa7ik1G+HewMLUvE2/cEsjLuL2dobviF7Jqu4le6fYRj7foKmA+IFOJwtg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-35aa6107e9fso16547595ab.0 for ; Tue, 14 Nov 2023 07:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699976386; x=1700581186; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ztg59d3TFT3VXG44UvPrQPHGjrj/OvuyajEhqQc32y0=; b=J4HKQ4ZnKrW8k/UF83vCJXvrfaFKxm1PEUUfJgXCnS1q9P2Si0SlTZ64Ph6j+YdHsj aNycuKgnClEwMlMX+H2yM3cfMgt+I6xBjcAqxYE2NNtmym4lZd0TQKIANho1TZn3JuRp fYiK8xt9hztSq5Z8hTHBT+5qLbAvGz+LthxHbuxcr0YhL8zgeU5p9OtC+Y3eW9HiFLWK fBiZjs5qMOzhEG4id1e6r0faoR71Zsz1rTwGR5iG8N3hnTomYpU3adiluTqGCqV2AqQ6 7lo0sADQ7GktfOokAoPU5tRy+XiXln8kc9PXo9vMVtwkLGQnDla1JQOvtPrLvqJzOIu4 eIfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699976386; x=1700581186; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ztg59d3TFT3VXG44UvPrQPHGjrj/OvuyajEhqQc32y0=; b=RzE9d9Oa+XjD7OhxF5ilyOIKG9enuMG6/Xn6sEj/MJDkw8X6U8O+orHJua8X+8im07 P8NmW588E4XClh+mB4G5R8d2200szNy57IRZMcwBWa0/t8nIRYMznVzQ6NN2/VTHts5F x1/45LbiWmc0OQNVmQYWMz4cWpbsTyFYpbXloZO0oJSkDBzNIqoOkdB0jFYrJX3nxR6A dbGJqkQGn8vHjl8YW2MJSDPCtqlRr5KfzwJb+w2qcA9CA/Q8ABdM7muEFCVwt4WyhNFW mkWBjhhUiCuIw9khLUugeU/ZyU1c8kbw4jVrawqOG7MW2IbF+b0q1i0ZufFw6WEerbY5 49zw== X-Gm-Message-State: AOJu0Yw8NlkFr+z34rcOyTGk/hsR3gZ5iq+Rqi8lWvH3qgPmbFuiep4R HJoVTEfiamTYpHQlsPIWpu3hB1Fiv0V3/Lo9ODlA+g== X-Google-Smtp-Source: AGHT+IEy+Hka/AUmB4ab1HEi9cezgQ9yjGybRyHohP38ntIZ/Eu4SDSS51AiDwr1KpWya6HyLf5I8A== X-Received: by 2002:a05:6e02:1a23:b0:359:4c9a:9a93 with SMTP id g3-20020a056e021a2300b003594c9a9a93mr12854474ile.31.1699976386600; Tue, 14 Nov 2023 07:39:46 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id fv12-20020a05663866cc00b004596858b397sm454645jab.7.2023.11.14.07.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 07:39:46 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Handle nested functions in DAP References: <20231101-dap-nested-function-v1-0-0b0c3b228ac7@adacore.com> X-Attribution: Tom Date: Tue, 14 Nov 2023 08:39:45 -0700 In-Reply-To: <20231101-dap-nested-function-v1-0-0b0c3b228ac7@adacore.com> (Tom Tromey's message of "Wed, 01 Nov 2023 11:09:32 -0600") Message-ID: <874jhoqr7i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> DAP doesn't really describe what to do for nested functions. We Tom> discussed it internally a little, and I came up with this series. The Tom> idea here is that variables from the outer scope ought to be visible, Tom> so this series lets Python code follow a frame's static link, and then Tom> changes the DAP frame decorators to use this ability. I'm going to check this in. I'm also going to backport it to gdb-14, since it is a change for DAP; and the generic changes should be pretty harmless. Tom> At some point I think we'll need a "frame decorator v2", like we added Tom> for pretty-printers. But, I've been putting this off a little and Tom> still haven't done it here. I think this is a bit trickier than it first appears, because frame filters not only generate objects that conform to the decorator API -- they also use them. So I'm not sure what to do, if the need really arises. Maybe we need to break the API a little. Tom