From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id 7369B385840E for ; Mon, 2 Oct 2023 17:00:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7369B385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-79fe612beabso309287839f.3 for ; Mon, 02 Oct 2023 10:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1696266019; x=1696870819; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=485BBlspet6QCCpupxU6g4zW2do4884TcXqMXTBP0zE=; b=SpUAmwp2UyFFjfVyrkDnsS7DY/lG1AOUkE9gTvPEoz55hcvtem6ip1BBoPe84Btm6N ekRD4G489T+Lbpw2MsjXGnVsAo3MQ75A2SH1RikWPgQznthJUnjmSdK7gotzOE4LWJXS LPdvZjuLUOEFvffIv/+cbbDH67OqX7UYX12wXF5Yb0/CHSr+jJlN0ZLLEqSx6TLnPwgz km2DhCwRzj687JZK1bKSF9AJd0QHjnxOMNAgu7KgVDTqAl8rutnQ/SNIGqKwrtdf37GQ iALZt58mmxv32WWLX92pVq0oGqBFL9CFde7rktzl6AS+jqNzsw6bki2oqVKDDUVCrIis mK3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696266019; x=1696870819; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=485BBlspet6QCCpupxU6g4zW2do4884TcXqMXTBP0zE=; b=vt6lrS6Xj2jfpAig6dqgTeX6OX972PjrojKlLSkumu9ZH0eFk62Svy24yvr1CTcj7y ZWbGrLS36RuX99Qaswp+NY6fOgXR8IpZRQOfROjAJM8xD0/X9g9upDCxeeUKbwAnaky4 qXfkNRDZZPz+5Jy/5k6YkrahEq8AbMqPmcISvEUDLHXAV+ZXwwhrL+a3mGSeTH3l5gga xNfP77M+48CHYeLMEj2ms0rMk+/bdyVuVo7XMCplG0pTYP4uTc3RMLIbWPevSNO0FeEU rqzMyGD6VrWQhFQNTQhK3LnvjlyadNKJ2bcE1aQ6cRbE1+KAy0mhEXikQirEpbbcSs0U zqLg== X-Gm-Message-State: AOJu0YzYlzG4lUuxYX0/PaI3ppSUDpZ+kTd0SmVCsCk7KqqBeb/8hkFP hzIQSUANQbX5QXm2huscqcehBg== X-Google-Smtp-Source: AGHT+IG3hASlawvh2fAu5A6q8tyPcZWkU2+C+6lbXq7mbhXYVYjgkY847i4FiLMbylTykkzUVFxM9w== X-Received: by 2002:a05:6e02:13d3:b0:34f:cd3c:e029 with SMTP id v19-20020a056e0213d300b0034fcd3ce029mr11491652ilj.13.1696266018498; Mon, 02 Oct 2023 10:00:18 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id q12-20020a92c00c000000b003514347f5d6sm1270701ild.50.2023.10.02.10.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 10:00:17 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCHv2 5/5] gdb: fix reread_symbols when an objfile has target: prefix References: <87il7u2mdo.fsf@tromey.com> <87pm21uvq9.fsf@redhat.com> <87lecl1500.fsf@tromey.com> <87fs2txb4y.fsf@redhat.com> X-Attribution: Tom Date: Mon, 02 Oct 2023 11:00:17 -0600 In-Reply-To: <87fs2txb4y.fsf@redhat.com> (Andrew Burgess's message of "Mon, 02 Oct 2023 17:05:49 +0100") Message-ID: <874jj90xjy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> We know that the value in reread_symbols comes from the system stat. So Andrew> what I'm missing, is the path by which objfile::mtime gets set from Andrew> anywhere other that within libbfd.a, such that it might get contaminated Andrew> by a gnulib stat result. I was digging some more and I found: commit d706b69e48268ccf3e95fd29b5374ac94c3a507b Author: Tom Tromey Date: Tue Sep 8 10:20:44 2020 -0600 Do not adjust mtime timezone on Windows ... where I put in a patch to disable gnulib's stat replacement. So I think your patch is totally fine, and I don't really know why I didn't land my other changes after this. Tom