From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id C099F3858D32 for ; Mon, 18 Sep 2023 18:21:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C099F3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-792623074edso138499639f.1 for ; Mon, 18 Sep 2023 11:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695061281; x=1695666081; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=oD1e0kO6xx+rXmPTDeszZRJCfZ4fUur76xQltSnxx3g=; b=TJlS/oJk3T6P+bAOMz/MGA2/RtafB+2/Z6QgeoFUtk1KkSRLQLmTWqugDngRY0y14j ql9SGIe5PP8bAgZZcEhaYG3Ij/T4ySqCxHXyMZaYnQewOJK4ySUcL33SxmfTgGm4gWoB HGFmfKMMXylS7BMroxYZLsn+sinT7W/Dif7tmfO6NGM3ddn+2sM4T50nxISk3FAWvifC bInyuLIwcHpMit6Nrlt7G2nW0Dn65uVwUtwlQozrasO8xpqTj6qo0mUC08uWp4AJVupG U2kGMQjWq0PnU+M9omRE+4JJvWnhVwBP+2k1ykpUlRH2YlNQkx/pNFgTgrwKeisYTeZ9 CbeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695061281; x=1695666081; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oD1e0kO6xx+rXmPTDeszZRJCfZ4fUur76xQltSnxx3g=; b=O23kluuuiTajg2SAfzabhvf8GkkW9NeecukYRq8CgRBUEkXPas+fdkjEAv+fFjz96p 1s70m1sW3VxmqbdR2ZCDRuXYfqrVBfbVIXZe8LBCgxysLvN9JQlexIv1M5YCgnmCpyaN hCyWhzjK2IPtm1duSdZJhAy4zZ/Ig2IoyU1G0BPBzUwoRKCNo/88a8ySvIQGWeZFWtQg 5xPzJ0ciMPLnwsLmlqfXgqiHRczxvASbMUePUVr3KrWWViyzHFjoz8YzpNggKxGgYJ+N mIiyqWodvzD3Qkf+w2vqmqRjMszqdr/28ZS2GpS0DsvVmowi/JaTbBua+AhLhG+NMGqt 1ekQ== X-Gm-Message-State: AOJu0YxKTJyOfRX6d80Q5Y9ZsDctNAiIekucb4GWK7mj0gI3s3m6/o2p vexzxwVoJrj2WHnKzNH4SilAiQ== X-Google-Smtp-Source: AGHT+IE7si3NSRKem6VqYzComC48/KV1HLiCdcw5rI3qiuGc88itgDR0KiEZYGXh9Vkk7oOKJ762YA== X-Received: by 2002:a05:6e02:2196:b0:346:15f5:2667 with SMTP id j22-20020a056e02219600b0034615f52667mr436927ila.4.1695061281664; Mon, 18 Sep 2023 11:21:21 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id o21-20020a02b815000000b004301f422fbdsm2902838jam.178.2023.09.18.11.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 11:21:21 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Move val_prettyformat to valprint.h References: <20230905183616.2042673-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 18 Sep 2023 12:21:19 -0600 In-Reply-To: <20230905183616.2042673-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Tue, 5 Sep 2023 12:36:16 -0600") Message-ID: <874jjr9wbk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> I stumbled across an ancient FIXME comment that was easy to fix -- Tom> val_prettyformat does not need to be in defs.h, and is easily moved to Tom> valprint.h, where (despite what the comment says) it belongs. Tom> Tested by rebuilding. I'm checking this in. Tom